RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Wednesday, October 31, 2018 2:17 PM > To: Miroslav Lichvar > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > intel-wired- > l...@lists.osuosl.org > Subject: Re: [RFC PATCH

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Richard Cochran
On Wed, Oct 31, 2018 at 03:49:35PM +0100, Miroslav Lichvar wrote: > > How about separating the PHC timestamp from the ptp_system_timestamp > structure and use NULL to indicate we don't want to read the system > clock? A gettimex64(ptp, ts, NULL) call would be equal to > gettime64(ptp, ts).

RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Keller, Jacob E
> -Original Message- > From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: Wednesday, October 31, 2018 7:40 AM > To: Miroslav Lichvar > Cc: Keller, Jacob E ; netdev@vger.kernel.org; > intel-wired- > l...@lists.osuosl.org > Subject: Re: [RFC PATCH

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Miroslav Lichvar
On Wed, Oct 31, 2018 at 07:40:03AM -0700, Richard Cochran wrote: > On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote: > > I think there could be a flag in ptp_system_timestamp, or a parameter > > of gettimex64(), which would enable/disable reading of the system > > clock. > > I'm

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-31 Thread Richard Cochran
On Mon, Oct 29, 2018 at 02:31:09PM +0100, Miroslav Lichvar wrote: > I think there could be a flag in ptp_system_timestamp, or a parameter > of gettimex64(), which would enable/disable reading of the system > clock. I'm not a fan of functions that change their behavior based on flags in their

RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-29 Thread Keller, Jacob E
n > > Subject: Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime > > On Fri, Oct 26, 2018 at 04:54:57PM +, Keller, Jacob E wrote: > > > -Original Message- > > > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > > > Sent: Friday,

Re: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-29 Thread Miroslav Lichvar
On Fri, Oct 26, 2018 at 04:54:57PM +, Keller, Jacob E wrote: > > -Original Message- > > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > > Sent: Friday, October 26, 2018 9:28 AM > > To: netdev@vger.kernel.org > > Cc: intel-wired-...@lists.osuosl.org; Richard Cochran > > ; > >

RE: [RFC PATCH 4/4] ixgbe: add support for extended PHC gettime

2018-10-26 Thread Keller, Jacob E
> -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Friday, October 26, 2018 9:28 AM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; Richard Cochran > ; > Keller, Jacob E ; Miroslav Lichvar > > Subject: [RFC PATCH 4/4] ixgbe: add