Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-28 Thread Andrew Lunn
> If this is a rare case and something future devices should get right, > then I'm more inclined to use 'dev-addr' rather than extending reg. Hi Rob The sample size is a bit small at the moment to know how rare it is. I think we have 6 C45 devices so far, and two get this wrong. C45 is mostly

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-28 Thread Rob Herring
On Tue, Mar 27, 2018 at 9:24 AM, Andrew Lunn wrote: >> > This is a 2nd MDIO address, right? Can't you just append this to reg >> > property? > > Hi Rob > > It is a sub address. > > There are two different MDIO addressing schemes. Clause 22 allowed for > 32 different addresses on

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-27 Thread Andrew Lunn
> > This is a 2nd MDIO address, right? Can't you just append this to reg > > property? Hi Rob It is a sub address. There are two different MDIO addressing schemes. Clause 22 allowed for 32 different addresses on an MDIO bus. Clause 45 extended that. You have the existing 32 addresses for a

RE: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-27 Thread Vicenţiu Galanopulo
mark.rutl...@arm.com; da...@davemloft.net; mar...@holtmann.org; > devicet...@vger.kernel.org > Cc: Madalin-cristian Bucur <madalin.bu...@nxp.com>; Alexandru Marginean > <alexandru.margin...@nxp.com> > Subject: Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr > and

RE: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-27 Thread Vicenţiu Galanopulo
net; mar...@holtmann.org; > devicet...@vger.kernel.org; Madalin-cristian Bucur <madalin.bu...@nxp.com>; > Alexandru Marginean <alexandru.margin...@nxp.com> > Subject: Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr > and dev-addr code check-up > &

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-26 Thread Florian Fainelli
On 03/23/2018 08:05 AM, Vicentiu Galanopulo wrote: > Reason for this patch is that the Inphi PHY has a > vendor specific address space for accessing the > C45 MDIO registers - starting from 0x1e. > > A search of the dev-addr property is done in of_mdiobus_register. > If the property is found in

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-26 Thread Rob Herring
On Fri, Mar 23, 2018 at 10:05:22AM -0500, Vicentiu Galanopulo wrote: > Reason for this patch is that the Inphi PHY has a > vendor specific address space for accessing the > C45 MDIO registers - starting from 0x1e. > > A search of the dev-addr property is done in of_mdiobus_register. > If the

Re: [RFC PATCH v2] net: phy: Added device tree binding for dev-addr and dev-addr code check-up

2018-03-23 Thread Andrew Lunn
> --- a/drivers/of/of_mdio.c > +++ b/drivers/of/of_mdio.c > @@ -24,6 +24,8 @@ > > #define DEFAULT_GPIO_RESET_DELAY 10 /* in microseconds */ > > +struct phy_c45_device_ids mdio_c45_ids = {0}; You do know that Linux is multi-threaded. It could be probing two MDIO busses at once.