Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-21 Thread David Miller
From: "Williams, Mitch A" Date: Thu, 20 Apr 2017 22:25:03 + > I'm not adding backdoor hooks to do naughty things, I'm just (very > slightly) enhancing what's already there. I'm not going to drop this series because of this. I'm just sounding the warning that I probably have to start pushing

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-21 Thread Or Gerlitz
On Thu, Apr 20, 2017 at 7:58 PM, David Miller wrote: > From: "Mintz, Yuval" > Date: Thu, 20 Apr 2017 16:24:51 + > >> the HW pipeline itself can't be abstracted in this case. > > I've heard that argument before, and I'm glad Jiri didn't drink the > koolaide and instead wrote dpipe. donno re d

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Williams, Mitch A
etdev@vger.kernel.org; > nhor...@redhat.com; sassm...@redhat.com; jogre...@redhat.com > Subject: Re: [net-next 04/14] i40e: dump VF information in debugfs > > From: "Mintz, Yuval" > Date: Thu, 20 Apr 2017 10:09:28 + > > >> > Dump some internal state ab

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 20:50:55 + > Nope, I don't mind doing the work. What I would appreciate is some > constructive suggestions on a seemingly feasible approach that might work. > I feel like I've been bashed enough for one day. :-) Well, it seems like the thing that y

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Mintz, Yuval
> > I surely wouldn't want to write a million lines of code just to > > provide such a detailed abstraction. > > So now the argument has gone from "it's not possible" to "it's going to be a > HUGE amount of code." Nothing here's is strictly impossible - you can always create a simulated HW model

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 20:12:59 + > I surely wouldn't want to write a million lines of code just to > provide such a detailed abstraction. So now the argument has gone from "it's not possible" to "it's going to be a HUGE amount of code." I wonder what the next argument

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Mintz, Yuval
> > the HW pipeline itself can't be abstracted in this case. > > I've heard that argument before, and I'm glad Jiri didn't drink the koolaide > and instead wrote dpipe. Perhaps "can't" was the wrong term to use, but I still believe there's an inherent problem with applying the dpipe approach here

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 16:24:51 + > the HW pipeline itself can't be abstracted in this case. I've heard that argument before, and I'm glad Jiri didn't drink the koolaide and instead wrote dpipe.

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Mintz, Yuval
> > I agree this surely isn't *our* convention, but for scsi using > > debugfs [or sysfs] is a common practice for debug purposes. > > > > Also, our HW debug capabilities are highly-customable, and I want to > > have the ability to configure those on the fly [E.g., dynamically > > configuring vari

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 13:57:08 + > I agree this surely isn't *our* convention, but for scsi using debugfs > [or sysfs] is a common practice for debug purposes. > > Also, our HW debug capabilities are highly-customable, and I want to > have the ability to configure thos

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread David Miller
From: "Mintz, Yuval" Date: Thu, 20 Apr 2017 10:09:28 + >> > Dump some internal state about VFs through debugfs. This provides >> > information not available with 'ip link show'. >> >> such as? >> >> donnwantobethedebugfspolice, but still, in the 2-3 times we tried to push >> debugfs to MLNX

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Mintz, Yuval
> >> > Dump some internal state about VFs through debugfs. This provides > >> > information not available with 'ip link show'. > >> > >> such as? > >> > >> donnwantobethedebugfspolice, but still, in the 2-3 times we tried to > >> push debugfs to MLNX NIC drivers, Dave disallowed that, and lately >

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Jiri Pirko
Thu, Apr 20, 2017 at 12:09:28PM CEST, yuval.mi...@cavium.com wrote: >> > Dump some internal state about VFs through debugfs. This provides >> > information not available with 'ip link show'. >> >> such as? >> >> donnwantobethedebugfspolice, but still, in the 2-3 times we tried to push >> debugfs

RE: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-20 Thread Mintz, Yuval
> > Dump some internal state about VFs through debugfs. This provides > > information not available with 'ip link show'. > > such as? > > donnwantobethedebugfspolice, but still, in the 2-3 times we tried to push > debugfs to MLNX NIC drivers, Dave disallowed that, and lately the switch > team eve

Re: [net-next 04/14] i40e: dump VF information in debugfs

2017-04-19 Thread Or Gerlitz
On Thu, Apr 20, 2017 at 4:57 AM, Jeff Kirsher wrote: > From: Mitch Williams > > Dump some internal state about VFs through debugfs. This provides > information not available with 'ip link show'. such as? donnwantobethedebugfspolice, but still, in the 2-3 times we tried to push debugfs to MLNX N