RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-14 Thread Ayaz Abdulla
Abdulla; [EMAIL PROTECTED]; netdev@vger.kernel.org Subject: Re: [patch 02/10] forcedeth: power down phy when interface is down On Thu, 13 Dec 2007 16:53:58 -0800 Ed Swierk [EMAIL PROTECTED] wrote: On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ayaz Abdulla
I would not include this patch until further testing is performed. NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it could have adverse affects on certain phys. Ayaz -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, December 13,

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Ed Swierk
On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable problem? Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link lights both on the NIC and the switch to go out when they bring an interface

RE: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Brandeburg, Jesse
Andrew Morton wrote: On Thu, 13 Dec 2007 16:11:55 -0800 Ayaz Abdulla [EMAIL PROTECTED] wrote: I would not include this patch until further testing is performed. NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it could have adverse affects on certain phys. Ayaz

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 16:11:55 -0800 Ayaz Abdulla [EMAIL PROTECTED] wrote: I would not include this patch until further testing is performed. NVIDIA MCP chips use 3rd party PHY vendors. By powering down the phy, it could have adverse affects on certain phys. Ayaz -Original

Re: [patch 02/10] forcedeth: power down phy when interface is down

2007-12-13 Thread Andrew Morton
On Thu, 13 Dec 2007 16:53:58 -0800 Ed Swierk [EMAIL PROTECTED] wrote: On 12/13/07, Andrew Morton [EMAIL PROTECTED] wrote: Does this patch actually fix any observeable problem? Without the patch, ifconfig down leaves the physical link up, which confuses datacenter users who expect the link