RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

erlitz...@gmail.com; > step...@networkplumber.org > Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode > > Hi Chris, > > On Mon, Jan 08, 2018 at 02:03:53AM +, Chris Mi wrote: > > > On Thu, Jan 04, 2018 at 04:34:51PM +0900, Chris Mi wrot

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

com; netdev@vger.kernel.org; gerlitz...@gmail.com > Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode > > On Mon, 8 Jan 2018 08:00:00 + > Chris Mi <chr...@mellanox.com> wrote: > > > > >> I wonder whether specifying the batch size is ne

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

erlitz...@gmail.com; > step...@networkplumber.org > Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode > > Hi Chris, > > On Mon, Jan 08, 2018 at 02:03:53AM +, Chris Mi wrote: > > > On Thu, Jan 04, 2018 at 04:34:51PM +0900, Chris Mi wrot

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

On Mon, 8 Jan 2018 08:00:00 + Chris Mi wrote: > > >> I wonder whether specifying the batch size is necessary at all. > > >> Couldn't batch mode just collect messages until either EOF or an > > >> incompatible command is encountered which then triggers a commit to > > >>

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

Hi Chris, On Mon, Jan 08, 2018 at 02:03:53AM +, Chris Mi wrote: > > On Thu, Jan 04, 2018 at 04:34:51PM +0900, Chris Mi wrote: > > > The insertion rate is improved more than 10%. > > > > Did you measure the effect of increasing batch sizes? > Yes. Even if we enlarge the batch size bigger than

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

> >> I wonder whether specifying the batch size is necessary at all. > >> Couldn't batch mode just collect messages until either EOF or an > >> incompatible command is encountered which then triggers a commit to > >> kernel? This might simplify code quite a bit. > > That's a good suggestion. > >

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

On 1/7/18 7:03 PM, Chris Mi wrote: >> Did you measure the effect of increasing batch sizes? > Yes. Even if we enlarge the batch size bigger than 10, there is no big > improvement. That will change over time so the tc command should allow auto-batching to work up to the message size limit. > I

RE: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

mber.org; dsah...@gmail.com; > marcelo.leit...@gmail.com > Subject: Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode > > Hi Chris, > > On Thu, Jan 04, 2018 at 04:34:51PM +0900, Chris Mi wrote: > > Currently in tc batch mode, only one command is read fr

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

On Fri, Jan 05, 2018 at 10:27:52AM -0700, David Ahern wrote: > On 1/5/18 10:25 AM, Phil Sutter wrote: > > I wonder whether specifying the batch size is necessary at all. Couldn't > > batch mode just collect messages until either EOF or an incompatible > > command is encountered which then triggers

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

On 1/5/18 10:25 AM, Phil Sutter wrote: > I wonder whether specifying the batch size is necessary at all. Couldn't > batch mode just collect messages until either EOF or an incompatible > command is encountered which then triggers a commit to kernel? This > might simplify code quite a bit. >

Re: [patch iproute2 v6 0/3] tc: Add -bs option to batch mode

Hi Chris, On Thu, Jan 04, 2018 at 04:34:51PM +0900, Chris Mi wrote: > Currently in tc batch mode, only one command is read from the batch > file and sent to kernel to process. With this patchset, we can accumulate > several commands before sending to kernel. The batch size is specified > using