RE: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-19 Thread Yotam Gigi
Or Gerlitz ; >geert+rene...@glider.be; step...@networkplumber.org; >xiyou.wangc...@gmail.com; li...@roeck-us.net; Shrijeet Mukherjee >; Yotam Gigi >Subject: Re: [patch net-next RFC 4/6] Introduce sample tc action > >On 10/18/16, 3:58 AM, Yotam Gigi wrote: > >> On 16-10-15

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-19 Thread Roopa Prabhu
On 10/18/16, 3:58 AM, Yotam Gigi wrote: > On 16-10-15 12:34 PM, Roopa Prabhu wrote: [snip] >> The OVS implementation is a good example, the metadata includes all the >> actions applied to the packet in the kernel data path. >>> Again not sure what the use case would be (and why waste su

RE: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-18 Thread Yotam Gigi
+rene...@glider.be; Stephen Hemminger >; Cong Wang ; >Guenter Roeck >Subject: Re: [patch net-next RFC 4/6] Introduce sample tc action > >On Wed, Oct 12, 2016 at 3:41 PM, Jiri Pirko wrote: >> From: Yotam Gigi >> >> This action allow the user to sample traffic ma

RE: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-18 Thread Yotam Gigi
Gerlitz >; geert+rene...@glider.be; >step...@networkplumber.org; xiyou.wangc...@gmail.com; li...@roeck-us.net; >Shrijeet Mukherjee >Subject: Re: [patch net-next RFC 4/6] Introduce sample tc action > >On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: >> >> Some comments: >>

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-17 Thread Roopa Prabhu
On 10/17/16, 5:17 PM, Roopa Prabhu wrote: > On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: [snip] inline below more data/context.. + +struct sample_packet_metadata { +int sample_size; +int orig_size; +int ifindex; +}; + >>> This metadata does not look

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-17 Thread Roopa Prabhu
On 10/17/16, 3:10 AM, Jamal Hadi Salim wrote: > > Some comments: > IIUC, the main struggle seems to be whether the redirect to dummy0 > is useful or not? i.e instead of just letting the packets go up the > stack on eth1? yep, correct...given existing workflow for the non-offloaded case is to recei

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-17 Thread Jamal Hadi Salim
Some comments: IIUC, the main struggle seems to be whether the redirect to dummy0 is useful or not? i.e instead of just letting the packets go up the stack on eth1? It seems like sflowd needs to read off eth1 via packet socket? To be backward compatible - supporting that approach seems sensible.

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-16 Thread Or Gerlitz
On Wed, Oct 12, 2016 at 3:41 PM, Jiri Pirko wrote: > From: Yotam Gigi > > This action allow the user to sample traffic matched by tc classifier. > The sampling consists of choosing packets randomly, truncating them, > adding some informative metadata regarding the interface and the original > pac

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-15 Thread Roopa Prabhu
On 10/15/16, 9:34 AM, Roopa Prabhu wrote: > On 10/12/16, 5:41 AM, Jiri Pirko wrote: >> From: Yotam Gigi >> >> This action allow the user to sample traffic matched by tc classifier. >> The sampling consists of choosing packets randomly, truncating them, >> adding some informative metadata regarding

Re: [patch net-next RFC 4/6] Introduce sample tc action

2016-10-15 Thread Roopa Prabhu
On 10/12/16, 5:41 AM, Jiri Pirko wrote: > From: Yotam Gigi > > This action allow the user to sample traffic matched by tc classifier. > The sampling consists of choosing packets randomly, truncating them, > adding some informative metadata regarding the interface and the original > packet size and