Re: bug in ixgbe_atr

2016-10-14 Thread Sowmini Varadhan
On (10/14/16 16:09), Duyck, Alexander H wrote: > Sorry I was thinking of a different piece of code. In the case of the > atr code it would be hdr.network, not hdr.raw. Basically the thought > was to validate that there is enough data in skb_headlen() that we can > verify that from where the

RE: bug in ixgbe_atr

2016-10-14 Thread Duyck, Alexander H
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Thursday, October 13, 2016 8:49 PM > To: Duyck, Alexander H <alexander.h.du...@intel.com> > Cc: netdev@vger.kernel.org > Subject: Re: bug in ixgbe_atr > > On (10/14

Re: bug in ixgbe_atr

2016-10-13 Thread Sowmini Varadhan
On (10/14/16 02:06), Duyck, Alexander H wrote: > > + case ETH_P_IP: > > + skb_header_pointer(skb, ETH_HLEN, sizeof (struct iphdr), > > + _hdr); > > /* access ihl as u8 to avoid unaligned access on ia64 */ > > - hlen = (hdr.network[0] &

RE: bug in ixgbe_atr

2016-10-13 Thread Duyck, Alexander H
> -Original Message- > From: Sowmini Varadhan [mailto:sowmini.varad...@oracle.com] > Sent: Thursday, October 13, 2016 6:44 PM > To: Duyck, Alexander H ; > netdev@vger.kernel.org > Subject: bug in ixgbe_atr > > When I was playing around with TPACKET_V2, I think