Re: RFC: XFRM changing the view of xfrm_aevent_id

2006-12-02 Thread jamal
On Fri, 2006-01-12 at 20:08 -0800, David Miller wrote: Let's change it now while we still can. A few months from now, I will probably not give the same answer :) :- Ok, here it is ... cheers, jamal [XFRM] fix aevent structuring to be more complete aevents can not uniquely identify an

Re: RFC: XFRM changing the view of xfrm_aevent_id

2006-12-02 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Sat, 02 Dec 2006 06:09:08 -0500 On Fri, 2006-01-12 at 20:08 -0800, David Miller wrote: Let's change it now while we still can. A few months from now, I will probably not give the same answer :) :- Ok, here it is ... Applied thanks. - To

RFC: XFRM changing the view of xfrm_aevent_id

2006-12-01 Thread jamal
while trying to patch iproute2 to display the xfrm aevents i came to the conclusion that the xfrm_aevent_id struct didnt provide enough info for me to uniquely identify an SA. I need two other items: the reqid and saddr. The structure currently looks like struct xfrm_aevent_id { struct

Re: RFC: XFRM changing the view of xfrm_aevent_id

2006-12-01 Thread KOVACS Krisztian
Hi, On Friday 01 December 2006 15:37, jamal wrote: struct xfrm_aevent_id { struct xfrm_usersa_id sa_id; __u32 flags; }; I could add the two items mentioned above in it and break the ABI. This may sound dangerous, but the usage of this

Re: RFC: XFRM changing the view of xfrm_aevent_id

2006-12-01 Thread David Miller
From: jamal [EMAIL PROTECTED] Date: Fri, 01 Dec 2006 09:37:52 -0500 The structure currently looks like struct xfrm_aevent_id { struct xfrm_usersa_id sa_id; __u32 flags; }; I could add the two items mentioned above in it and break the