Jeff Garzik wrote:
Looks pretty decent. Main comments (style mostly, driver operation path
seems sound):
thanks again for the comments. I am about to send an updated patch just before
my
vacation and before I do let me just quickly touch on your comments below:
* kill the bitfields and
Looks pretty decent. Main comments (style mostly, driver operation path
seems sound):
* kill the bitfields and unions [in descriptor structs]. they are not
endian-safe as presented, generate poor code, and are otherwise undesirable.
* the basic operations are too verbose:
Kok, Auke wrote:
All,
here is the second version of the igb (82575) ethernet controller driver. This
driver was previously posted 2007-07-13. Many comments received were
addressed:
- removed indirection wrappers in the same way as e1000e and ixgbe.
- cleaned up largely against sparse,
