On 22-07-2007 09:05, David Miller wrote:
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 19 Jul 2007 17:27:47 +0100
Please revisit the requirements that netconsole needs and redesign
it from scratch. The existing code is causing too much breakage.
Can it be done without breaking the
From: Stephen Hemminger [EMAIL PROTECTED]
Date: Thu, 19 Jul 2007 17:27:47 +0100
Please revisit the requirements that netconsole needs and redesign
it from scratch. The existing code is causing too much breakage.
Can it be done without breaking the semantics of network devices, or
should we
On Thursday 12 July 2007 04:33, David Miller wrote:
I'll add merge your patch with a target of 2.6.23
If you really want, after this patch has sat in 2.6.23 for a while
and got some good testing, we can consider a submission for -stable.
Okay, those of you who followed the discussion on lkml
On Thu, 19 Jul 2007 17:19:19 +0200
Olaf Kirch [EMAIL PROTECTED] wrote:
On Thursday 12 July 2007 04:33, David Miller wrote:
I'll add merge your patch with a target of 2.6.23
If you really want, after this patch has sat in 2.6.23 for a while
and got some good testing, we can consider a
On Fri, Jul 13, 2007 at 10:55:08AM +0200, Jarek Poplawski wrote:
On Thu, Jul 12, 2007 at 03:54:32PM +0200, Olaf Kirch wrote:
...
One thing I was a little worried about was whether dev-npinfo can
go away all of a sudden. It's really just protected by an rcu_readlock...
...
BTW, I don't think
On Thu, Jul 12, 2007 at 03:54:32PM +0200, Olaf Kirch wrote:
Hi Jarek,
On Thursday 12 July 2007 14:59, Jarek Poplawski wrote:
+#ifdef CONFIG_NETPOLL
+ /* Prevent race with netpoll - yes, this is a kludge.
+ * But at least it doesn't penalize the non-netpoll
+ * code path. */
Hi!
I'm really sorry I couldn't write this sooner.
Below are a few of my doubts:
On 10-07-2007 12:44, Olaf Kirch wrote:
On Tuesday 10 July 2007 00:27, David Miller wrote:
I'm happy to entertain this kind of solution, but we really
need to first have an interface to change multiple bits
at a
Hi Jarek,
On Thursday 12 July 2007 14:59, Jarek Poplawski wrote:
+#ifdef CONFIG_NETPOLL
+ /* Prevent race with netpoll - yes, this is a kludge.
+* But at least it doesn't penalize the non-netpoll
+* code path. */
Alas, this can penalize those who have it enabled (e.g. by
On Wednesday 11 July 2007 07:44, David Miller wrote:
+#ifdef CONFIG_NETPOLL
+ /* Prevent race with netpoll - yes, this is a kludge.
+* But at least it doesn't penalize the non-netpoll
+* code path. */
+ if (test_bit(__LINK_STATE_POLL_LIST_FROZEN, dev-state))
+
From: Olaf Kirch [EMAIL PROTECTED]
Date: Wed, 11 Jul 2007 09:41:37 +0200
On Wednesday 11 July 2007 07:44, David Miller wrote:
+#ifdef CONFIG_NETPOLL
+ /* Prevent race with netpoll - yes, this is a kludge.
+ * But at least it doesn't penalize the non-netpoll
+ * code path. */
+
On Tuesday 10 July 2007 00:27, David Miller wrote:
I'm happy to entertain this kind of solution, but we really
need to first have an interface to change multiple bits
at a time in one atomic operation, because by itself this
patch doubles the number of atomices we do when starting
a NAPI
From: Olaf Kirch [EMAIL PROTECTED]
Date: Tue, 10 Jul 2007 12:44:31 +0200
On Tuesday 10 July 2007 00:27, David Miller wrote:
I'm happy to entertain this kind of solution, but we really
need to first have an interface to change multiple bits
at a time in one atomic operation, because by
From: Olaf Kirch [EMAIL PROTECTED]
Date: Wed, 4 Jul 2007 14:16:32 +0200
Another locking bug in netpoll, why am I not surprised? :-/
Thanks for reporting this Olaf.
I think the only real fix for this is to restrict who is allowed
to remove the interface from the poll_list. Only net_rx_action
13 matches
Mail list logo
