Re: [PATCH][RFC] softmac: suggest TX rate

2006-04-17 Thread Johannes Berg
On Mon, 2006-04-17 at 01:28 +0100, Daniel Drake wrote: Rather than having to explicitly call ieee80211softmac_suggest_tx_rate() from the driver's hard_start_xmit function, it would be nicer if the suggested rate was passed as a parameter. But not all drivers would need it, so maybe the

Re: [PATCH][RFC] softmac: suggest TX rate

2006-04-17 Thread Daniel Drake
Johannes Berg wrote: Couldn't we just initialise the softmac txrates substructure to something useful when associating, and have drivers look into that instead? How about this? It also addresses the fact that multicast data must be transmitted at a basic rate. ---

Re: [PATCH][RFC] softmac: suggest TX rate

2006-04-16 Thread Ulrich Kunitz
On Mon, 17 Apr 2006, Daniel Drake wrote: While developing the ZD1211 driver we realised how much we'd like to be advised from the upper layers which rate to transmit a packet at. An example: We have a frame to transmit. What rate should we transmit it at? While taking any user-specified

Re: [PATCH][RFC] softmac: suggest TX rate

2006-04-16 Thread Ulrich Kunitz
On Mon, 17 Apr 2006, Ulrich Kunitz wrote: Oops! Sorry, but sometime ^X and ^C are to near to each other. I just wanted to say, I agree with the approach, but wonder how transmission timeouts come into play here, which should lead to a decrease of the tranmission rate. Daniel the patches on

Re: [PATCH][RFC] softmac: suggest TX rate

2006-04-16 Thread Daniel Drake
Ulrich Kunitz wrote: I just wanted to say, I agree with the approach, but wonder how transmission timeouts come into play here, which should lead to a decrease of the tranmission rate. That's a separate issue, to do with rate management, which I'm not tackling yet. Note that the functions in