Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Christoph Hellwig
On Tue, May 08, 2007 at 10:29:03AM +0200, Tomasz Chmielewski wrote: Michael Jones wrote: +#ifndef __ARMEB__ +#warning Little endian mode not supported +#endif Personally I'm less fussed about WAN / LE support. Anyone with any sense will run ixp4xx boards doing such a specialised

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Lennert Buytenhek
On Wed, May 16, 2007 at 08:13:01AM +0100, Christoph Hellwig wrote: +#ifndef __ARMEB__ +#warning Little endian mode not supported +#endif Personally I'm less fussed about WAN / LE support. Anyone with any sense will run ixp4xx boards doing such a specialised network operation as

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Michael-Luke Jones
On 16 May 2007, at 10:41, Lennert Buytenhek wrote: Making a driver work in both modes of operation is generally not just an issue of adding a couple of be32_to_cpu()s in the right places. While this comment is technically correct, Christian's driver achieves endian agnostic operation with

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Rod Whitby
Lots of people wrote: Lots of huffing and puffing about endian support by this driver ... For what it's worth, the NSLU2-Linux project (which has over 10,000 known users of our custom ixp4xx firmware, most of which will eventually be users of this new driver) is *endian-neutral*. We support

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Lennert Buytenhek
On Wed, May 16, 2007 at 08:16:38PM +0930, Rod Whitby wrote: So, if the author of these patches wishes to concentrate on big-endian support first, then we will not say (and have not said) anything which will block inclusion of a big-endian only version of this driver. The NSLU2 people are the

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Rod Whitby
Lennert Buytenhek wrote: On Wed, May 16, 2007 at 08:16:38PM +0930, Rod Whitby wrote: So, if the author of these patches wishes to concentrate on big-endian support first, then we will not say (and have not said) anything which will block inclusion of a big-endian only version of this driver.

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Lennert Buytenhek
On Wed, May 16, 2007 at 09:05:18PM +0930, Rod Whitby wrote: So, if the author of these patches wishes to concentrate on big-endian support first, then we will not say (and have not said) anything which will block inclusion of a big-endian only version of this driver. The NSLU2 people

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Krzysztof Halasa
Christoph Hellwig [EMAIL PROTECTED] writes: Not even trying to support LE is a clear merge blocker. Maybe Krzysztof can't actually test it himself, which is fine - but not even pretending to be endian clean is not what proper Linux drivers do. The drivers can only work with IXP4xx CPU and

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-16 Thread Krzysztof Halasa
Rod Whitby [EMAIL PROTECTED] writes: Please let's just stop arguing about it. If a patch appears before it gets merged, then great. If it doesn't then it will appear at a later date. Sure. The swapping patch is trivial and I can add it if needed at some point but I hope we can do that data

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-15 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 03:45:53PM +0100, Michael-Luke Jones wrote: No-one is saying that this driver should not be mainlined before it has LE support. All that I said was: Personally I'd like LE ethernet tested and working before we push. The alternative would be to explicitly state

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Marcus Better
Krzysztof Halasa wrote: Lennert Buytenhek [EMAIL PROTECTED] writes: There _is_ an ARM BE version of Debian. It's not an official port, but it's not maintained any worse than the 'official' LE ARM Debian port is. Hmm... That changes a bit. Perhaps we should forget about that LE thing then,

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 10:58:06AM +0200, Marcus Better wrote: There _is_ an ARM BE version of Debian. It's not an official port, but it's not maintained any worse than the 'official' LE ARM Debian port is. Hmm... That changes a bit. Perhaps we should forget about that LE thing

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Marcus Better
Lennert Buytenhek wrote: Does that mean that the Debian ARM people have their heads so far up their collective asses that they think that every form of change is bad and are unable to accept that some forms of change might be for the better? Well, I am not one of the Debian ARM people, just a

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Mikael Pettersson
On Wed, 9 May 2007 11:35:03 +0200, Marcus Better wrote: Lennert Buytenhek wrote: Does that mean that the Debian ARM people have their heads so far up their collective asses that they think that every form of change is bad and are unable to accept that some forms of change might be for the

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Tomasz Chmielewski
On Wed, 9 May 2007 11:35:03 +0200, Marcus Better wrote: Lennert Buytenhek wrote: Does that mean that the Debian ARM people have their heads so far up their collective asses that they think that every form of change is bad and are unable to accept that some forms of change might be for the

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 11:35:03AM +0200, Marcus Better wrote: Does that mean that the Debian ARM people have their heads so far up their collective asses that they think that every form of change is bad and are unable to accept that some forms of change might be for the better? Well,

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Lennert Buytenhek
On Wed, May 09, 2007 at 12:35:40PM +0200, Mikael Pettersson wrote: Does that mean that the Debian ARM people have their heads so far up their collective asses that they think that every form of change is bad and are unable to accept that some forms of change might be for the better?

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread David Acker
Lennert Buytenhek wrote: The people who need a LE network driver can use Christian's driver, as Christian's driver works in LE just fine. The people who care about LE support can add LE support to the driver that Krzysztof wrote. I don't think that not supporting LE is a reason not to merge

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-09 Thread Michael-Luke Jones
On 9 May 2007, at 15:22, David Acker wrote: Big endian is the natural setup for the NPEs on this hardware according to the intel documentation. Please don't stop this driver from moving forward so that a few folks can run their hardware in slow mode. No-one is saying that this driver

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Michael-Luke Jones
On 8 May 2007, at 02:19, Krzysztof Halasa wrote: Adds a driver for built-in IXP4xx Ethernet MAC and HSS ports Signed-off-by: Krzysztof Halasa [EMAIL PROTECTED] diff --git a/arch/arm/mach-ixp4xx/ixdp425-setup.c b/arch/arm/mach- ixp4xx/ixdp425-setup.c index ec4f079..f20d39d 100644 ---

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Michael-Luke Jones
On 8 May 2007, at 09:26, Mikael Pettersson wrote: On Tue, 8 May 2007 08:22:17 +0100, Michael-Luke Jones wrote: AFAIK, it's a HW limitation of the IXP4xx NPEs, or possibly Intel's microcode for them. I run my IXP42x boxes big-endian and don't mind doing so. /Mikael *cough*

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Mikael Pettersson
On Tue, 8 May 2007 08:22:17 +0100, Michael-Luke Jones wrote: On 8 May 2007, at 02:19, Krzysztof Halasa wrote: Adds a driver for built-in IXP4xx Ethernet MAC and HSS ports ... +#ifndef __ARMEB__ +#warning Little endian mode not supported +#endif This has gone from error to warning -

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Tomasz Chmielewski
Michael Jones wrote: +#ifndef __ARMEB__ +#warning Little endian mode not supported +#endif Personally I'm less fussed about WAN / LE support. Anyone with any sense will run ixp4xx boards doing such a specialised network operation as BE. Also, NSLU2-Linux can't test this functionality with

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Michael-Luke Jones
On 8 May 2007, at 09:48, Alexey Zaytsev wrote: I was always curious, why do people want to run ixp4xx in LE mode? What are the benefits that overweight the obvious performance degradation? Debian. http://www.debian.org/ports/arm/ Michael-Luke - To unsubscribe from this list: send the line

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Tomasz Chmielewski
Alexey Zaytsev schrieb: On 5/8/07, Tomasz Chmielewski [EMAIL PROTECTED] wrote: Michael Jones wrote: +#ifndef __ARMEB__ +#warning Little endian mode not supported +#endif Personally I'm less fussed about WAN / LE support. Anyone with any sense will run ixp4xx boards doing such a

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Gordon Farquharson
On 5/8/07, Alexey Zaytsev [EMAIL PROTECTED] wrote: I was always curious, why do people want to run ixp4xx in LE mode? What are the benefits that overweight the obvious performance degradation? Debian on the NSLU2 runs in LE, and it is pretty popular.

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Krzysztof Halasa
Lennert Buytenhek [EMAIL PROTECTED] writes: +/* Built-in 10/100 Ethernet MAC interfaces */ +static struct mac_plat_info ixdp425_plat_mac[] = { +{ +.phy= 0, +.rxq= 3, +}, { +.phy= 1, +.rxq

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 04:31:12PM +0200, Krzysztof Halasa wrote: +/* Built-in 10/100 Ethernet MAC interfaces */ +static struct mac_plat_info ixdp425_plat_mac[] = { + { + .phy= 0, + .rxq= 3, + }, { + .phy= 1, +

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Krzysztof Halasa
Alexey Zaytsev [EMAIL PROTECTED] writes: I was always curious, why do people want to run ixp4xx in LE mode? What are the benefits that overweight the obvious performance degradation? Debian is indeed a valid reason. I wonder if it would be much work to create BE Debian as well. Simple

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Lennert Buytenhek
On Tue, May 08, 2007 at 05:28:21PM +0200, Krzysztof Halasa wrote: I was always curious, why do people want to run ixp4xx in LE mode? What are the benefits that overweight the obvious performance degradation? Debian is indeed a valid reason. I wonder if it would be much work to create BE

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Krzysztof Halasa
Lennert Buytenhek [EMAIL PROTECTED] writes: The board support code knows such things as that the front ethernet port on the board is connected to the CPU's MII port number #2, but the board support code does _not_ know that MII port number #2 corresponds to ixp4xx hardware queue #5. Sure.

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Krzysztof Halasa
Lennert Buytenhek [EMAIL PROTECTED] writes: There _is_ an ARM BE version of Debian. It's not an official port, but it's not maintained any worse than the 'official' LE ARM Debian port is. Hmm... That changes a bit. Perhaps we should forget about that LE thing then, and (at best) put that

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Tomasz Chmielewski
Krzysztof Halasa schrieb: Lennert Buytenhek [EMAIL PROTECTED] writes: There _is_ an ARM BE version of Debian. It's not an official port, but it's not maintained any worse than the 'official' LE ARM Debian port is. Hmm... That changes a bit. Perhaps we should forget about that LE thing then,

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-08 Thread Krzysztof Halasa
Tomasz Chmielewski [EMAIL PROTECTED] writes: Does using ixp4xx on LE have any other drawbacks than inferior network performance? More memory is needed, something like max 600 KB for 2 Ethernet ports. And talking about network performance, what numbers are we talking about (LE vs BE; 30%

Re: [PATCH] Intel IXP4xx network drivers v.2 - Ethernet and HSS

2007-05-07 Thread Jeff Garzik
ACK. I shall presume that the ARM folks will apply these patches. You may tack on an Acked-by: Jeff Garzik [EMAIL PROTECTED] onto the ethernet driver itself. I'll let the ARM folks review the rest. I do agree with the comments in the thread that -- as in your most recent revision -- the