Re: [PATCH] sunhme: convert printk to pr_cont

2018-08-17 Thread David Miller
From: Mikulas Patocka Date: Fri, 17 Aug 2018 16:08:49 -0400 (EDT) > I'm not an expert on networking code - you can change it if it is more > appropriate this way. What Stephen is asking of you doesn't require networking expertiece and he even gave you an example of how to do it. All you would

Re: [PATCH] sunhme: convert printk to pr_cont

2018-08-17 Thread Mikulas Patocka
On Fri, 17 Aug 2018, Stephen Hemminger wrote: > On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) > Mikulas Patocka wrote: > > > === > > --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 > > 18:11:00.0 +0200

Re: [PATCH] sunhme: convert printk to pr_cont

2018-08-17 Thread Stephen Hemminger
On Fri, 17 Aug 2018 15:12:22 -0400 (EDT) Mikulas Patocka wrote: > === > --- linux-stable.orig/drivers/net/ethernet/sun/sunhme.c 2018-04-20 > 18:11:00.0 +0200 > +++ linux-stable/drivers/net/ethernet/sun/sunhme.c

Re: [PATCH] sunhme: convert printk to pr_cont

2018-08-17 Thread David Miller
From: Mikulas Patocka Date: Fri, 17 Aug 2018 15:12:22 -0400 (EDT) > The kernel adds newlines automatically unless pr_cont is used. This patch > converts sunhme to use pr_cont, so that the messages are not broken to > multiple lines. > > The patch also adds "\n" to a few strings that were