Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-11 Thread Yafang Shao
2017-11-11 3:32 GMT+00:00 Steven Rostedt : > On Sat, 11 Nov 2017 02:06:00 + > Yafang Shao wrote: > >> 2017-11-10 15:07 GMT+00:00 Steven Rostedt : >> > On Fri, 10 Nov 2017 12:56:06 +0800 >> > Yafang Shao

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Steven Rostedt
On Sat, 11 Nov 2017 02:06:00 + Yafang Shao wrote: > 2017-11-10 15:07 GMT+00:00 Steven Rostedt : > > On Fri, 10 Nov 2017 12:56:06 +0800 > > Yafang Shao wrote: > > > >> Could the macro tcp_state_name() be renamed ？ > >> If is

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Yafang Shao
2017-11-10 15:07 GMT+00:00 Steven Rostedt : > On Fri, 10 Nov 2017 12:56:06 +0800 > Yafang Shao wrote: > >> Could the macro tcp_state_name() be renamed ？ >> If is included in include/net/tcp.h, it will > > Ideally, you don't want to include

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Song Liu
> On Nov 10, 2017, at 7:07 AM, Steven Rostedt wrote: > > On Fri, 10 Nov 2017 12:56:06 +0800 > Yafang Shao wrote: > >> Could the macro tcp_state_name() be renamed ？ >> If is included in include/net/tcp.h, it will > > Ideally, you don't want to

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-10 Thread Steven Rostedt
On Fri, 10 Nov 2017 12:56:06 +0800 Yafang Shao wrote: > Could the macro tcp_state_name() be renamed ？ > If is included in include/net/tcp.h, it will Ideally, you don't want to include trace/events/*.h headers in other headers, as they can have side effects if those

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-09 Thread Yafang Shao
2017-11-10 8:57 GMT+08:00 Steven Rostedt : > > From: "Steven Rostedt (VMware)" > > The TCP trace events (specifically tcp_set_state), maps emums to symbol > names via __print_symbolic(). But this only works for reading trace events > from the tracefs

Re: [PATCH] tcp: Export to userspace the TCP state names for the trace events

2017-11-09 Thread Song Liu
> On Nov 9, 2017, at 4:57 PM, Steven Rostedt wrote: > > > From: "Steven Rostedt (VMware)" > > The TCP trace events (specifically tcp_set_state), maps emums to symbol > names via __print_symbolic(). But this only works for reading trace events > from