Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On 03/16/2018 04:14 PM, Andrew Lunn wrote: I agree, let's not have you run into circles, let's just use your patches as they are since they fix the problem and are not intrusive in any way. Agreed, this is too complex, for little gain. Thanks. v2 posted. -- regards, -grygorii

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

> I agree, let's not have you run into circles, let's just use your > patches as they are since they fix the problem and are not intrusive in > any way. Agreed, this is too complex, for little gain. Andrew

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On 03/16/2018 01:13 PM, Grygorii Strashko wrote: > > > On 03/16/2018 02:54 PM, Andrew Lunn wrote: >>> The phydrv->mdiodrv.flags can be accessible only after call to >>> of_phy_connect()/phy_connect(), >> >> You need to use a function like of_phy_find_device() to get the >> phydev, set the flag,

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

> The phydrv->mdiodrv.flags can be accessible only after call to > of_phy_connect()/phy_connect(), You need to use a function like of_phy_find_device() to get the phydev, set the flag, and then call phy_connect_direct(). Andrew

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On 03/16/2018 02:11 PM, Florian Fainelli wrote: > On March 16, 2018 11:42:21 AM PDT, Grygorii Strashko > wrote: >> >> >> On 03/16/2018 12:34 PM, Florian Fainelli wrote: >>> >>> >>> On 03/16/2018 10:22 AM, Andrew Lunn wrote: On Wed, Mar 14, 2018 at 05:26:22PM

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On 03/16/2018 02:54 PM, Andrew Lunn wrote: >> The phydrv->mdiodrv.flags can be accessible only after call to >> of_phy_connect()/phy_connect(), > > You need to use a function like of_phy_find_device() to get the > phydev, set the flag, and then call phy_connect_direct(). So, do you propose

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On March 16, 2018 11:42:21 AM PDT, Grygorii Strashko wrote: > > >On 03/16/2018 12:34 PM, Florian Fainelli wrote: >> >> >> On 03/16/2018 10:22 AM, Andrew Lunn wrote: >>> On Wed, Mar 14, 2018 at 05:26:22PM -0500, Grygorii Strashko wrote: Some ethernet drivers (like

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On 03/16/2018 12:34 PM, Florian Fainelli wrote: > > > On 03/16/2018 10:22 AM, Andrew Lunn wrote: >> On Wed, Mar 14, 2018 at 05:26:22PM -0500, Grygorii Strashko wrote: >>> Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per >>> one netdevice, as result such drivers will

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On 03/16/2018 10:22 AM, Andrew Lunn wrote: > On Wed, Mar 14, 2018 at 05:26:22PM -0500, Grygorii Strashko wrote: >> Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per >> one netdevice, as result such drivers will produce warning during system >> boot and fail to connect

Re: [PATCH 0/2] net: phy: relax error checking when creating sysfs link netdev->phydev

On Wed, Mar 14, 2018 at 05:26:22PM -0500, Grygorii Strashko wrote: > Some ethernet drivers (like TI CPSW) may connect and manage >1 Net PHYs per > one netdevice, as result such drivers will produce warning during system > boot and fail to connect second phy to netdevice when PHYLIB framework >