Re: [PATCH 0/6] rework d80211 cookie pointer

2006-11-03 Thread Michael Wu
On Thursday 02 November 2006 17:38, Johannes Berg wrote: I'm sorry I didn't manage to update these drivers. As for out-of-tree drivers, I obviously haven't updated them either. It *shouldn't* be too hard as the net_dev shouldn't be used in many places. So uh, what am I going to prefix all my

Re: [PATCH 0/6] rework d80211 cookie pointer

2006-11-03 Thread Johannes Berg
Michael Wu wrote: So uh, what am I going to prefix all my printk messages with now that I can't access dev-name? It seems like the other d80211 drivers have a habit of prefixing their messages with the driver name (wrong thing to do, IMHO), which is different from pretty much all other

Re: [PATCH 0/6] rework d80211 cookie pointer

2006-11-03 Thread Michael Wu
On Friday 03 November 2006 14:08, Johannes Berg wrote: Yeah, I thought about that and added that function to get the wiphy index. cfg80211 makes the wiphy index an actual identifier that you can use to enumerate all devices it has attached etc, so that makes sense. and d80211 also puts it into

Re: [PATCH 0/6] rework d80211 cookie pointer

2006-11-03 Thread Johannes Berg
On Fri, 2006-11-03 at 17:14 -0500, Michael Wu wrote: I still prefer obtaining the name of the master interface because well.. all other network drivers prefix their messages with the name of their interface. The master interface name should be as good as the wiphy index to enumerate

Re: [PATCH 0/6] rework d80211 cookie pointer

2006-11-02 Thread Michael Wu
On Thursday 02 November 2006 17:38, Johannes Berg wrote: Now, I tried to update adm8211 and rt2x00 as well, but faced some problems. adm8211 actually accesses the struct net_device and calls it's open() call! This is broken. Good catch. Looks like I never updated the suspend/resume code