Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

2016-01-04 Thread David Miller
From: Heinrich Schuchardt Date: Tue, 29 Dec 2015 23:22:02 +0100 > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. > > Signed-off-by: Heinrich Schuchardt Please enhance your commit log message to include the analysis you

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

2015-12-30 Thread Heinrich Schuchardt
On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote: > Hi Heinrich, > > On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: >> IOCTL SIOCRTMSG does nothing but return EINVAL. >> >> So comment it as unused. > > Can you say something about how you confirmed this? > It's not immediately

Re: [PATCH 1/1] include/uapi/linux/sockios.h: mark SIOCRTMSG unused

2015-12-30 Thread Michael Kerrisk (man-pages)
Hi Heinrich, On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. Can you say something about how you confirmed this? It's not immediately obvious from the code. Cheers, Michael > Signed-off-by: Heinrich Schuchardt