Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-23 11:49 GMT+02:00 Alexander Stein : >> The registers are set to some reset values after the chip is coming out of >> reset, but we should set them all to the same value, Mathias said that all >> except for one board he knows are using only one LED

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

Hi Hauke, On Monday 23 May 2016 09:12:54, Mehrtens, Hauke wrote: > > On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > > > 2016-05-19 9:03 GMT+02:00 John Crispin : > > > > On 19/05/2016 08:57, Alexander Stein wrote: > > > >> Thanks for the link, I wasn't aware of that

RE: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

.faine...@gmail.com>; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; and...@lunn.ch; > Mehrtens, Hauke <hauke.mehrt...@intel.com> > Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver > > On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > > 2016-05-19 9:03 GM

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

> To be honest I don't know how the PHY LEDs could be set by LED triggers. > Wouldn't that require to create triggers for each value which can be written > to LEDxH and LEDxL? In my case the hardware requires some specific setting > due > to LED connections. Supporting all possibilities is

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

On Thursday 19 May 2016 12:03:10, Mathias Kresin wrote: > 2016-05-19 9:03 GMT+02:00 John Crispin : > > On 19/05/2016 08:57, Alexander Stein wrote: > >> Thanks for the link, I wasn't aware of that patch. I like it in general, > >> but there are some things I'd like to get

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

2016-05-19 9:03 GMT+02:00 John Crispin : > On 19/05/2016 08:57, Alexander Stein wrote: >> Thanks for the link, I wasn't aware of that patch. I like it in general, but >> there are some things I'd like to get addressed first: >> * vr9_gphy_of_reg_init() writes uncoditionally to

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

On Thursday 19 May 2016 09:03:26, John Crispin wrote: > [ changing haukes mail addr to the intel one ] > > On 19/05/2016 08:57, Alexander Stein wrote: > > Hi John, > > > > On Thursday 19 May 2016 06:50:56, John Crispin wrote: > >> On 18/05/2016 18:24, Florian Fainelli wrote: > >>> CC'ing Andrew,

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

On Wednesday 18 May 2016 19:01:09, Andrew Lunn wrote: > > For LEDs, we had a patch series floating around adding LED triggers [1], > > and it seems to me like the LEDs class subsystem would be a good fit for > > controlling PHY LEDs, possibly with the help of PHYLIB when it comes to > > doing the

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

[ changing haukes mail addr to the intel one ] On 19/05/2016 08:57, Alexander Stein wrote: > Hi John, > > On Thursday 19 May 2016 06:50:56, John Crispin wrote: >> On 18/05/2016 18:24, Florian Fainelli wrote: >>> CC'ing Andrew, John, >> >> also CC'ing Matthias and Hauke. we have had a driver in

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

Hi John, On Thursday 19 May 2016 06:50:56, John Crispin wrote: > On 18/05/2016 18:24, Florian Fainelli wrote: > > CC'ing Andrew, John, > > also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for > several years that seems a little more complete than this one. > >

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

Hi, On 18/05/2016 18:24, Florian Fainelli wrote: > CC'ing Andrew, John, > also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for several years that seems a little more complete than this one.

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

> For LEDs, we had a patch series floating around adding LED triggers [1], > and it seems to me like the LEDs class subsystem would be a good fit for > controlling PHY LEDs, possibly with the help of PHYLIB when it comes to > doing the low-level work of registering LEDs and their names with the >

Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver

CC'ing Andrew, John, On 05/18/2016 09:03 AM, Alexander Stein wrote: > This currently only supports PEF7071 and allows to specify max-speed and > is able to read the LED configuration from device-tree. > > Signed-off-by: Alexander Stein > --- > The main