Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Thu, Apr 12, 2018 at 12:16:58AM +0800, Xin Long wrote: > On Wed, Apr 11, 2018 at 10:59 PM, Marcelo Ricardo Leitner > wrote: > > On Wed, Apr 11, 2018 at 10:36:07AM -0400, Neil Horman wrote: > >> On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > >> >

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

From: Xin Long Date: Thu, 12 Apr 2018 00:16:58 +0800 > What do you think of: > > static int sctp_v6_cmp_addr(const union sctp_addr *addr1, > const union sctp_addr *addr2) > { > return __sctp_v6_cmp_addr(addr1, addr2) && >

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 10:59 PM, Marcelo Ricardo Leitner wrote: > On Wed, Apr 11, 2018 at 10:36:07AM -0400, Neil Horman wrote: >> On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: >> > pf->cmp_addr() is called before binding a v6 address to the sock. It >> >

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 10:36:07AM -0400, Neil Horman wrote: > On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > > pf->cmp_addr() is called before binding a v6 address to the sock. It > > should not check ports, like in sctp_inet_cmp_addr. > > > > But sctp_inet6_cmp_addr checks the addr

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

From: Xin Long Date: Wed, 11 Apr 2018 20:58:05 +0800 > @@ -863,10 +863,31 @@ static int sctp_inet6_cmp_addr(const union sctp_addr > *addr1, > if (sctp_is_any(sk, addr1) || sctp_is_any(sk, addr2)) > return 1; > > - if (addr1->sa.sa_family !=

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 11:42:41AM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > > pf->cmp_addr() is called before binding a v6 address to the sock. It > > should not check ports, like in sctp_inet_cmp_addr. > > > > But sctp_inet6_cmp_addr

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > pf->cmp_addr() is called before binding a v6 address to the sock. It > should not check ports, like in sctp_inet_cmp_addr. > > But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, > sctp_v6_cmp_addr where it also compares

Re: [PATCH net] sctp: do not check port in sctp_inet6_cmp_addr

On Wed, Apr 11, 2018 at 08:58:05PM +0800, Xin Long wrote: > pf->cmp_addr() is called before binding a v6 address to the sock. It > should not check ports, like in sctp_inet_cmp_addr. > > But sctp_inet6_cmp_addr checks the addr by invoking af(6)->cmp_addr, > sctp_v6_cmp_addr where it also compares