Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device

2018-04-01 Thread David Miller
From: Hangbin Liu Date: Fri, 30 Mar 2018 09:44:00 +0800 > Just like function ethtool_get_ts_info(), we should also consider the > phy_driver ts_info call back. For example, driver dp83640. > > Fixes: 37dd9255b2f6 ("vlan: Pass ethtool get_ts_info queries to real device.") > Acked-by: Richard Coch

Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device

2018-03-30 Thread Andrew Lunn
On Fri, Mar 30, 2018 at 08:21:21AM -0700, Richard Cochran wrote: > On Fri, Mar 30, 2018 at 05:02:14PM +0200, Andrew Lunn wrote: > > Would it not be better to just call ethtool_get_ts_info() on the real > > device? That would then also deal with the case that the 'real' device > > is another virtual

Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device

2018-03-30 Thread Andrew Lunn
On Fri, Mar 30, 2018 at 09:44:00AM +0800, Hangbin Liu wrote: > Just like function ethtool_get_ts_info(), we should also consider the > phy_driver ts_info call back. For example, driver dp83640. Hi Hangbin Would it not be better to just call ethtool_get_ts_info() on the real device? That would the

Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device

2018-03-30 Thread Richard Cochran
On Fri, Mar 30, 2018 at 05:02:14PM +0200, Andrew Lunn wrote: > Would it not be better to just call ethtool_get_ts_info() on the real > device? That would then also deal with the case that the 'real' device > is another virtual device stacked on top of a real device. That won't work. The returned