Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-18 Thread Girish Moodalbail
TL DR; There is indeed a race between geneve_changelink() and geneve transmit path w.r.t attributes being changed and the old value of those attributes being used in the transmit patch. I will resubmit V2 of the patch with those issues addressed. Thanks! Please see in-line for my other

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-16 Thread Girish Moodalbail
On 5/16/17 12:31 PM, David Miller wrote: From: Girish Moodalbail Date: Mon, 15 May 2017 10:47:04 -0700 if (data[IFLA_GENEVE_REMOTE]) { - info.key.u.ipv4.dst = + info->key.u.ipv4.dst =

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-16 Thread Pravin Shelar
On Mon, May 15, 2017 at 10:47 AM, Girish Moodalbail wrote: > This patch adds changelink rtnl operation support for geneve devices. > Code changes involve: > - refactor geneve_newlink into geneve_nl2info to be used by both > geneve_newlink and geneve_changelink

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-16 Thread David Miller
From: Girish Moodalbail Date: Mon, 15 May 2017 10:47:04 -0700 > if (data[IFLA_GENEVE_REMOTE]) { > - info.key.u.ipv4.dst = > + info->key.u.ipv4.dst = > nla_get_in_addr(data[IFLA_GENEVE_REMOTE]); > > -

Re: [PATCH net-next] geneve: add rtnl changelink support

2017-05-08 Thread David Miller
From: Girish Moodalbail Date: Mon, 8 May 2017 13:08:24 -0700 > This patch adds changelink rtnl operation support for geneve devices. > Code changes involve: > - refactor geneve_newlink into geneve_nl2info to be used by both > geneve_newlink and