Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-17 Thread Paolo Abeni
On Tue, 2016-02-16 at 15:40 -0500, David Miller wrote: > > Oh yes, I'm mixing different parts of the conversation. We must > > accept on RX zero checksum fields even for ipv6 because of the way the > > VXLAN RFC is worded, correct. > > Paolo, can you please respin your patch against 'net'? I

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread David Miller
From: Tom Herbert Date: Tue, 16 Feb 2016 13:31:34 -0800 > On Feb 16, 2016 12:53 PM, "David Miller" wrote: >> And practically speaking we disappear from the internet for VXLAN tunnel >> endpoints implementing the VXLAN spec properly. >> >> That's not

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread David Miller
From: Tom Herbert Date: Tue, 16 Feb 2016 12:50:23 -0800 > On Feb 16, 2016 12:40 PM, "David Miller" wrote: >> >> From: Jesse Gross >> Date: Tue, 16 Feb 2016 12:11:57 -0800 >> >> > On Tue, Feb 16, 2016 at 11:47 AM, David Miller

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread David Miller
From: David Miller Date: Tue, 16 Feb 2016 15:40:04 -0500 (EST) > Oh yes, I'm mixing different parts of the conversation. We must > accept on RX zero checksum fields even for ipv6 because of the way the > VXLAN RFC is worded, correct. Paolo, can you please respin your patch

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread David Miller
From: Jesse Gross Date: Tue, 16 Feb 2016 12:11:57 -0800 > On Tue, Feb 16, 2016 at 11:47 AM, David Miller wrote: >> From: Jesse Gross >> Date: Tue, 16 Feb 2016 10:22:38 -0800 >> >>> On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread Jesse Gross
On Tue, Feb 16, 2016 at 11:47 AM, David Miller wrote: > From: Jesse Gross > Date: Tue, 16 Feb 2016 10:22:38 -0800 > >> On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: >> There's a bigger problem here, not really related to lightweight

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread David Miller
From: Jesse Gross Date: Tue, 16 Feb 2016 10:22:38 -0800 > On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: > There's a bigger problem here, not really related to lightweight tunnels or > OVS. > > The VXLAN RFC says (referring to the UDP checksum and not

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-16 Thread Jesse Gross
On Thu, Feb 11, 2016 at 2:41 AM, Jiri Benc wrote: > On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net >> *net, const char *name, >>

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Jiri Benc
On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: > --- a/drivers/net/geneve.c > +++ b/drivers/net/geneve.c > @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net > *net, const char *name, > return dev; > > err = geneve_configure(net, dev,

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread David Miller
From: Jiri Benc Date: Thu, 11 Feb 2016 11:41:24 +0100 > On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: >> --- a/drivers/net/geneve.c >> +++ b/drivers/net/geneve.c >> @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net >> *net, const char *name, >>

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Jiri Benc
On Thu, 11 Feb 2016 13:16:52 +0100, Jiri Benc wrote: > I don't see a better way out of this now. Fortunately, this does not > affect route based tunneling. > > Acked-by: Jiri Benc Oh, and this should go to net, not net-next. Jiri -- Jiri Benc

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Jiri Benc
On Thu, 11 Feb 2016 12:38:51 +0100, Paolo Abeni wrote: > We are already sending by default zero UDP checksum when tunneling over > vxlan/geneve light weight tunnel since the commit 35e2d1152b22 > ("tunnels: Allow IPv6 UDP checksums to be correctly controlled."). > > Currently, geneve/vxlan lwt

Re: [PATCH net-next] lwt: fix rx checksum setting for lwt devices tunneling over ipv6

2016-02-11 Thread Paolo Abeni
On Thu, 2016-02-11 at 11:41 +0100, Jiri Benc wrote: > On Wed, 10 Feb 2016 16:47:21 +0100, Paolo Abeni wrote: > > --- a/drivers/net/geneve.c > > +++ b/drivers/net/geneve.c > > @@ -1441,7 +1441,8 @@ struct net_device *geneve_dev_create_fb(struct net > > *net, const char *name, > >