Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2016-01-04 Thread David Miller
From: Xin Long Date: Wed, 30 Dec 2015 23:50:45 +0800 > for telecom center, the usual case is that a server is connected by thousands > of clients. but if the server with only one enpoint(udp style) use the same > sport and dport to communicate with every clients, and every

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread Marcelo Ricardo Leitner
On Wed, Dec 30, 2015 at 12:19:39PM -0500, Eric Dumazet wrote: > On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > > > besides, this patchset will use transport hashtable to replace > > association hashtable to lookup with rhashtable api. get transport > > first then get association by t->asoc.

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread David Miller
From: Eric Dumazet Date: Wed, 30 Dec 2015 14:11:20 -0500 > Let see how funny it will be then. It is more fun than waiting longer for the more limited uses of it to trigger problems. I cannot be convinced that using it in more places in order to find and fix more bugs is

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread Eric Dumazet
On Wed, 2015-12-30 at 12:52 -0500, David Miller wrote: > From: Eric Dumazet > Date: Wed, 30 Dec 2015 12:19:39 -0500 > > > Switching SCTP to rhashtable at this moment is premature, it is > > still moving fast. > > I completely, and totally, disagree. > > rhashtable

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread David Miller
From: Eric Dumazet Date: Wed, 30 Dec 2015 14:03:43 -0500 > You sure can disagree with me, but calling my opinion 'incredily > stupid' is not wise. I think fundamentally giving facilities less rather than more coverage is not a smart approach at all. If the code is that

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread Eric Dumazet
On Wed, 2015-12-30 at 15:32 -0200, Marcelo Ricardo Leitner wrote: > On Wed, Dec 30, 2015 at 12:19:39PM -0500, Eric Dumazet wrote: > > On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > > > > > besides, this patchset will use transport hashtable to replace > > > association hashtable to lookup

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread Eric Dumazet
On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > besides, this patchset will use transport hashtable to replace > association hashtable to lookup with rhashtable api. get transport > first then get association by t->asoc. and also it will make tcp > style work better. SCTP already has a hash

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread Marcelo Ricardo Leitner
Em 30-12-2015 19:57, Eric Dumazet escreveu: On Wed, 2015-12-30 at 15:44 -0500, David Miller wrote: It is more fun than waiting longer for the more limited uses of it to trigger problems. I cannot be convinced that using it in more places in order to find and fix more bugs is a bad thing. I'm

Re: [PATCH net-next 0/5] sctp: use transport hashtable to replace association's with rhashtable

2015-12-30 Thread Eric Dumazet
On Wed, 2015-12-30 at 15:44 -0500, David Miller wrote: > It is more fun than waiting longer for the more limited uses of it to > trigger problems. > > I cannot be convinced that using it in more places in order to find > and fix more bugs is a bad thing. > > I'm sorry if a lot of bug fixes in a