Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-16 Thread Andrew Lunn
> Take a look at how the 'device_irq' local variable is used in > mv88e6xxx_g2_irq_setup. You assign it to 'err' in an error > path before it is ever set to anything. > > I think you meant to use the structure's 'device_irq' member > instead. Hi David Agreed. Thanks for the review.

Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-16 Thread David Miller
From: David Miller Date: Wed, 16 Nov 2016 14:21:02 -0500 (EST) > From: Andrew Lunn > Date: Wed, 16 Nov 2016 01:56:50 +0100 > >> The interrupt code was never tested with a board who's probing >> resulted in an -EPROBE_DEFFERED. So the clean up paths never

Re: [PATCH net-next 0/6] Fixes for the MV88e6xxx interrupt code

2016-11-16 Thread David Miller
From: Andrew Lunn Date: Wed, 16 Nov 2016 01:56:50 +0100 > The interrupt code was never tested with a board who's probing > resulted in an -EPROBE_DEFFERED. So the clean up paths never got > tested. I now do have -EPROBE_DEFFERED, and things break badly during > cleanup. These are