Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Gavin Shan
On Thu, Jul 07, 2016 at 10:32:12AM -0700, Florian Fainelli wrote: >On 07/02/2016 10:32 PM, Gavin Shan wrote: >> This series rebases on David's linux-net git repo ("master" branch). It's >> to support NCSI stack on net/farady/ftgmac100.c >> >> The following figure gives an example about how NCSI

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Benjamin Herrenschmidt
On Thu, 2016-07-07 at 10:32 -0700, Florian Fainelli wrote: > > I know nothing about NCSI, pretty much like Jon Snow, but from a cursory > look at your patches, is not there a way to make the NCSCI capable > network devices strictly adhere to the net_device APIs and calling > conventions? They

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Florian Fainelli
On 07/02/2016 10:32 PM, Gavin Shan wrote: > This series rebases on David's linux-net git repo ("master" branch). It's > to support NCSI stack on net/farady/ftgmac100.c > > The following figure gives an example about how NCSI is deployed: The NCSI is > specified by DSP0222, which can be downloaded

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Gavin Shan
On Thu, Jul 07, 2016 at 04:44:02PM +0300, Or Gerlitz wrote: >On Thu, Jul 7, 2016 at 12:17 PM, Benjamin Herrenschmidt > wrote: >> On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote: >>> On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov >>>

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Or Gerlitz
On Thu, Jul 7, 2016 at 12:17 PM, Benjamin Herrenschmidt wrote: > On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote: >> On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov >> wrote: >> > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Gavin Shan
On Thu, Jul 07, 2016 at 07:17:36PM +1000, Benjamin Herrenschmidt wrote: >On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote: >> On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov >> wrote: >> > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote: >> >> > Or,

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Benjamin Herrenschmidt
On Thu, 2016-07-07 at 19:17 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote: > > On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov > > wrote: > > > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote: > > > > > Or,

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Benjamin Herrenschmidt
On Thu, 2016-07-07 at 12:12 +0300, Or Gerlitz wrote: > On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov > wrote: > > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote: > > > Or, since cx4 has ncsi as well, could you do a thorough review of this > > to

Re: [PATCH net-next 00/10] NCSI Support

2016-07-07 Thread Or Gerlitz
On Tue, Jul 5, 2016 at 8:44 PM, Alexei Starovoitov wrote: > On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote: > Or, since cx4 has ncsi as well, could you do a thorough review of this > to make sure that it fits mellanox nics as well? Hi Alexei, all Yuval

Re: [PATCH net-next 00/10] NCSI Support

2016-07-05 Thread Benjamin Herrenschmidt
On Tue, 2016-07-05 at 19:07 -0700, Alexei Starovoitov wrote: > > Great! Thanks for clarifying. > So then future netlink api is mandatory to drive this kernel patches? > How one can use this set without it? The netlink API is to tweak things, it works reasonably well autonomously without it. >

Re: [PATCH net-next 00/10] NCSI Support

2016-07-05 Thread Alexei Starovoitov
On Wed, Jul 06, 2016 at 07:42:39AM +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-07-05 at 10:44 -0700, Alexei Starovoitov wrote: > > > >  .../... > > > > > The design for the patchset is highlighted as below: > > > > > > > >    * The NCSI interface is abstracted with "struct ncsi_dev".

Re: [PATCH net-next 00/10] NCSI Support

2016-07-05 Thread Benjamin Herrenschmidt
On Tue, 2016-07-05 at 10:44 -0700, Alexei Starovoitov wrote: >  .../... > > > The design for the patchset is highlighted as below: > > > > > >    * The NCSI interface is abstracted with "struct ncsi_dev". It's > > > registered > > >  when net_device is created, started to work by calling

Re: [PATCH net-next 00/10] NCSI Support

2016-07-05 Thread Alexei Starovoitov
On Mon, Jul 04, 2016 at 01:03:06AM +0300, Or Gerlitz wrote: > On Sun, Jul 3, 2016 at 8:32 AM, Gavin Shan wrote: > > This series rebases on David's linux-net git repo ("master" branch). It's > > to support NCSI stack on net/farady/ftgmac100.c > > > > The following figure

Re: [PATCH net-next 00/10] NCSI Support

2016-07-03 Thread Gavin Shan
On Mon, Jul 04, 2016 at 08:49:31AM +1000, Benjamin Herrenschmidt wrote: >On Mon, 2016-07-04 at 01:03 +0300, Or Gerlitz wrote: >> FWIW, talking to a colleague, he made a comment that some of the text >> above is wrong: >> >> AENs are sent from NIC to BMC. Not from Host to BMC. > >Just a typo in

Re: [PATCH net-next 00/10] NCSI Support

2016-07-03 Thread Benjamin Herrenschmidt
On Mon, 2016-07-04 at 01:03 +0300, Or Gerlitz wrote: > FWIW, talking to a colleague, he made a comment that some of the text > above is wrong: > > AENs are sent from NIC to BMC. Not from Host to BMC. Just a typo in the commit message thankfully ;-) > The traffic between a BMC and a NIC is over

Re: [PATCH net-next 00/10] NCSI Support

2016-07-03 Thread Or Gerlitz
On Sun, Jul 3, 2016 at 8:32 AM, Gavin Shan wrote: > This series rebases on David's linux-net git repo ("master" branch). It's > to support NCSI stack on net/farady/ftgmac100.c > > The following figure gives an example about how NCSI is deployed: The NCSI is > specified