Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-03 Thread Julian Anastasov
Hello, On Tue, 2 Feb 2016, Salam Noureddine wrote: > On Tue, Feb 2, 2016 at 12:55 PM, Julian Anastasov wrote: > > > > If the rule is once per net, the above call... > > > >> } > > > > should be here: > > > >

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-03 Thread Salam Noureddine
On Wed, Feb 3, 2016 at 12:08 AM, Julian Anastasov wrote: > Aha, I see, it is after NETDEV_UNREGISTER but may be > the above loop should be changed to two loops so that > NETDEV_UNREGISTER_BATCH is called exactly after all > NETDEV_UNREGISTER and before all dev_*_flush and >

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-02 Thread Julian Anastasov
Hello, On Mon, 1 Feb 2016, Salam Noureddine wrote: > @@ -1572,8 +1582,12 @@ rollback: > call_netdevice_notifier(nb, NETDEV_GOING_DOWN, > dev); > call_netdevice_notifier(nb,

Re: [PATCH net-next 2/4] net: dev: add batching to net_device notifiers

2016-02-02 Thread Salam Noureddine
On Tue, Feb 2, 2016 at 12:55 PM, Julian Anastasov wrote: > > Hello, > > On Mon, 1 Feb 2016, Salam Noureddine wrote: > >> @@ -1572,8 +1582,12 @@ rollback: >> call_netdevice_notifier(nb, NETDEV_UNREGISTER, dev); >> +