Re: [PATCH net-next 6/8] tools: bpftool: print all relevant byte opcodes for "load double word"

2017-10-20 Thread Quentin Monnet
On 20 October 2017 at 17:12, Daniel Borkmann wrote: > On 10/20/2017 05:50 PM, Quentin Monnet wrote: > [...] >> >> The remaining four bytes are taken from the "immediate" field of the >> second >> instruction, which leaves the first four fields (offset, source and >>

Re: [PATCH net-next 6/8] tools: bpftool: print all relevant byte opcodes for "load double word"

2017-10-20 Thread Daniel Borkmann
On 10/20/2017 05:50 PM, Quentin Monnet wrote: [...] The remaining four bytes are taken from the "immediate" field of the second instruction, which leaves the first four fields (offset, source and destination registers, and in particular opcode) unused. As far as I know, these fields remain at

Re: [PATCH net-next 6/8] tools: bpftool: print all relevant byte opcodes for "load double word"

2017-10-20 Thread Quentin Monnet
Hi David, On 20 October 2017 at 10:59, David Laight wrote: > From: Jakub Kicinski >> Sent: 19 October 2017 23:46 >> The eBPF instruction permitting to load double words (8 bytes) into a >> register need 8-byte long "immediate" field, and thus occupy twice the >> space of

Re: [PATCH net-next 6/8] tools: bpftool: print all relevant byte opcodes for "load double word"

2017-10-20 Thread Daniel Borkmann
On 10/20/2017 12:46 AM, Jakub Kicinski wrote: From: Quentin Monnet The eBPF instruction permitting to load double words (8 bytes) into a register need 8-byte long "immediate" field, and thus occupy twice the space of other instructions. bpftool was aware of this

RE: [PATCH net-next 6/8] tools: bpftool: print all relevant byte opcodes for "load double word"

2017-10-20 Thread David Laight
From: Jakub Kicinski > Sent: 19 October 2017 23:46 > The eBPF instruction permitting to load double words (8 bytes) into a > register need 8-byte long "immediate" field, and thus occupy twice the > space of other instructions. bpftool was aware of this and would > increment the instruction counter