Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread David Miller
From: Jiri Pirko Date: Wed, 2 Nov 2016 08:35:02 +0100 > How do you imagine this mode should looks like? Could you draw me some > example? Well, first of all, there is no reason we can't provide a mechanism by which the driver can request and obtain a FIB dump. And it can be designed in a way to

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Jiri Pirko
Wed, Nov 02, 2016 at 03:35:03PM CET, ro...@cumulusnetworks.com wrote: >On 11/2/16, 6:48 AM, Jiri Pirko wrote: >> Wed, Nov 02, 2016 at 02:29:40PM CET, ro...@cumulusnetworks.com wrote: >>> On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetwo

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Roopa Prabhu
On 11/2/16, 6:48 AM, Jiri Pirko wrote: > Wed, Nov 02, 2016 at 02:29:40PM CET, ro...@cumulusnetworks.com wrote: >> On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: >>> Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >> [snip] >> I understand..but, if you are adding some

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Jiri Pirko
Wed, Nov 02, 2016 at 02:29:40PM CET, ro...@cumulusnetworks.com wrote: >On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: >> Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >>> >[snip] > >>>I understand..but, if you are adding some core infrastructure for switchdev >>>..it c

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Ido Schimmel
On Wed, Nov 02, 2016 at 06:29:40AM -0700, Roopa Prabhu wrote: > On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: > > Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: > >> > [snip] > > >>I understand..but, if you are adding some core infrastructure for switchdev > >>..it ca

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Roopa Prabhu
On Wed, Nov 2, 2016 at 12:20 AM, Jiri Pirko wrote: > Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >> [snip] >>I understand..but, if you are adding some core infrastructure for switchdev >>..it cannot be >>based on the number of simple use-cases or data you have today. >>

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Jiri Pirko
Tue, Nov 01, 2016 at 04:36:50PM CET, da...@davemloft.net wrote: >From: Roopa Prabhu >Date: Tue, 01 Nov 2016 08:14:14 -0700 > >> On 11/1/16, 7:19 AM, Eric Dumazet wrote: >>> On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: >>>

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-02 Thread Jiri Pirko
Wed, Nov 02, 2016 at 03:13:42AM CET, ro...@cumulusnetworks.com wrote: >On 11/1/16, 10:03 AM, Ido Schimmel wrote: >> Hi Roopa, >> >> On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote: >>> >[snip] >>> I have the same concern as Eric here. >>> >>> I understand why you need it, but can the d

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-01 Thread Roopa Prabhu
On 11/1/16, 10:03 AM, Ido Schimmel wrote: > Hi Roopa, > > On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote: >> [snip] >> I have the same concern as Eric here. >> >> I understand why you need it, but can the driver request for an initial dump >> and that >> dump be made more efficient s

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-01 Thread Ido Schimmel
Hi Roopa, On Tue, Nov 01, 2016 at 08:14:14AM -0700, Roopa Prabhu wrote: > On 11/1/16, 7:19 AM, Eric Dumazet wrote: > > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: > >> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > >>> How well will this work for large FIB tables ? > >>

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-01 Thread Ido Schimmel
On Tue, Nov 01, 2016 at 07:19:59AM -0700, Eric Dumazet wrote: > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: > > On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > > > > How well will this work for large FIB tables ? > > > > > > Holding rtnl while sending thousands of skb w

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-01 Thread David Miller
From: Roopa Prabhu Date: Tue, 01 Nov 2016 08:14:14 -0700 > On 11/1/16, 7:19 AM, Eric Dumazet wrote: >> On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: >>> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: How well will this work for large FIB tables ? Holding rtn

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-01 Thread Roopa Prabhu
On 11/1/16, 7:19 AM, Eric Dumazet wrote: > On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: >> On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: >>> How well will this work for large FIB tables ? >>> >>> Holding rtnl while sending thousands of skb will prevent consumers to >>> mak

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-11-01 Thread Eric Dumazet
On Tue, 2016-11-01 at 00:57 +0200, Ido Schimmel wrote: > On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > > How well will this work for large FIB tables ? > > > > Holding rtnl while sending thousands of skb will prevent consumers to > > make progress ? > > Can you please clarify w

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-10-31 Thread Ido Schimmel
On Mon, Oct 31, 2016 at 02:24:06PM -0700, Eric Dumazet wrote: > On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote: > > From: Ido Schimmel > > > > When registering a FIB notifier block we should notify the caller of > > already existing FIB entries and rules, as it would otherwise have an

Re: [PATCH net-next v2] ipv4: fib: Replay events when registering FIB notifier

2016-10-31 Thread Eric Dumazet
On Mon, 2016-10-31 at 23:13 +0200, ido...@idosch.org wrote: > From: Ido Schimmel > > When registering a FIB notifier block we should notify the caller of > already existing FIB entries and rules, as it would otherwise have an > incomplete view of the FIB tables. This is especially important for >