RE: [PATCH v1 RFC 7/7] Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers

2017-10-18 Thread Tristram.Ha
> > +#define KSZ9477_INGRESS_TAG_LEN2 > > +#define KSZ9477_PTP_TAG_LEN4 > > +#define KSZ9477_PTP_TAG_INDICATION 0x80 > > + > > +#define KSZ9477_TAIL_TAG_OVERRIDE BIT(9) > > +#define KSZ9477_TAIL_TAG_LOOKUPBIT(10) > > + > > +static int ksz9477_get_tag(u8

Re: [PATCH v1 RFC 7/7] Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers

2017-10-14 Thread Andrew Lunn
On Fri, Oct 06, 2017 at 01:33:05PM -0700, tristram...@microchip.com wrote: > From: Tristram Ha > > Modify tag_ksz.c so that tail tag code can be used by other KSZ switch > drivers. There is multiple things going on in this patch. Please split the special_mult_addr

Re: [PATCH v1 RFC 7/7] Modify tag_ksz.c so that tail tag code can be used by other KSZ switch drivers

2017-10-11 Thread Pavel Machek
Hi! > +#define KSZ_INGRESS_TAG_LEN 1 This define is now (or should be) unused, so you can delete it, no? > _#define KSZ_EGRESS_TAG_LEN 1 And I'd delete this define, too. Having constant for something that's variable is quite confusing :-). Plus you are really doing