Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-25 Thread Kalle Valo
Arend Van Spriel writes: > On 25-4-2017 9:38, Arend Van Spriel wrote: >> On 24-4-2017 15:03, James Hughes wrote: >>> The driver was making changes to the skb_header without >>> ensuring it was writable (i.e. uncloned). >>> This patch also removes some boiler plate

Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-25 Thread Arend Van Spriel
On 25-4-2017 9:38, Arend Van Spriel wrote: > On 24-4-2017 15:03, James Hughes wrote: >> The driver was making changes to the skb_header without >> ensuring it was writable (i.e. uncloned). >> This patch also removes some boiler plate header size >> checking/adjustment code as that is also handled

Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-25 Thread Arend Van Spriel
On 24-4-2017 15:03, James Hughes wrote: > The driver was making changes to the skb_header without > ensuring it was writable (i.e. uncloned). > This patch also removes some boiler plate header size > checking/adjustment code as that is also handled by the > skb_cow_header function used to make

Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-24 Thread Arend Van Spriel
On 24-4-2017 15:03, James Hughes wrote: > The driver was making changes to the skb_header without > ensuring it was writable (i.e. uncloned). > This patch also removes some boiler plate header size > checking/adjustment code as that is also handled by the > skb_cow_header function used to make

Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-24 Thread Arend Van Spriel
On 24-4-2017 20:09, Eric Dumazet wrote: > On Mon, 2017-04-24 at 14:03 +0100, James Hughes wrote: >> The driver was making changes to the skb_header without >> ensuring it was writable (i.e. uncloned). >> This patch also removes some boiler plate header size >> checking/adjustment code as that is

Re: [PATCH v2] brcmfmac: Make skb header writable before use

2017-04-24 Thread Eric Dumazet
On Mon, 2017-04-24 at 14:03 +0100, James Hughes wrote: > The driver was making changes to the skb_header without > ensuring it was writable (i.e. uncloned). > This patch also removes some boiler plate header size > checking/adjustment code as that is also handled by the > skb_cow_header function