Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-07 Thread Iyappan Subramanian
Hi Russell, On Thu, Jul 7, 2016 at 7:14 AM, Russell King - ARM Linux wrote: > On Thu, Jul 07, 2016 at 04:03:02PM +0200, Andrew Lunn wrote: >> > Wed, Jul 06, 2016 at 04:44:44PM -0700, Iyappan Subramanian wrote: >> > Hi Andrew, >> > >> > On Tue, Jul 5, 2016 at 6:49 AM,

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-07 Thread Iyappan Subramanian
Hi Andrew, On Thu, Jul 7, 2016 at 7:03 AM, Andrew Lunn wrote: >> Wed, Jul 06, 2016 at 04:44:44PM -0700, Iyappan Subramanian wrote: >> Hi Andrew, >> >> On Tue, Jul 5, 2016 at 6:49 AM, Andrew Lunn wrote: >> > On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-07 Thread Russell King - ARM Linux
On Thu, Jul 07, 2016 at 04:03:02PM +0200, Andrew Lunn wrote: > > Wed, Jul 06, 2016 at 04:44:44PM -0700, Iyappan Subramanian wrote: > > Hi Andrew, > > > > On Tue, Jul 5, 2016 at 6:49 AM, Andrew Lunn wrote: > > > On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan Subramanian wrote:

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-07 Thread Andrew Lunn
> Wed, Jul 06, 2016 at 04:44:44PM -0700, Iyappan Subramanian wrote: > Hi Andrew, > > On Tue, Jul 5, 2016 at 6:49 AM, Andrew Lunn wrote: > > On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan Subramanian wrote: > >> Hi Andrew, > >> > >> Thanks for the review. > >> > >> On Tue, May

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-06 Thread Iyappan Subramanian
Hi Andrew, On Tue, Jul 5, 2016 at 6:49 AM, Andrew Lunn wrote: > On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan Subramanian wrote: >> Hi Andrew, >> >> Thanks for the review. >> >> On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: >> > On Tue, May 31, 2016 at

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-05 Thread Andrew Lunn
On Mon, Jun 06, 2016 at 10:12:35AM -0700, Iyappan Subramanian wrote: > Hi Andrew, > > Thanks for the review. > > On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: > > On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subramanian wrote: > >> +static int xgene_mdio_reset(struct

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-07-04 Thread Iyappan Subramanian
Hi Andrew, Thanks for the review. On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: > On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subramanian wrote: >> +static int xgene_mdio_reset(struct xgene_mdio_pdata *pdata) >> +{ >> + int ret; >> + >> + if (pdata->mdio_id

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-06-06 Thread Iyappan Subramanian
Hi Andrew, Thanks for the review. On Tue, May 31, 2016 at 6:11 PM, Andrew Lunn wrote: > On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subramanian wrote: >> +static int xgene_mdio_reset(struct xgene_mdio_pdata *pdata) >> +{ >> + int ret; >> + >> + if (pdata->mdio_id

Re: [PATCH v2 3/5] drivers: net: phy: Add MDIO driver

2016-05-31 Thread Andrew Lunn
On Tue, May 31, 2016 at 05:10:38PM -0700, Iyappan Subramanian wrote: > +static int xgene_mdio_reset(struct xgene_mdio_pdata *pdata) > +{ > + int ret; > + > + if (pdata->mdio_id == XGENE_MDIO_RGMII) { > + if (pdata->dev->of_node) { > +