RE: [PATCH v2 net-next 7/9] lan743x: Add EEE support

2018-07-13 Thread Bryan.Whitehead
> > +static int lan743x_ethtool_set_eee(struct net_device *netdev, > > + struct ethtool_eee *eee) > > +{ > > Hi Bryan > > You should call phy_ethtool_set_eee() in both cases, so that it gets disabled > in the PHY as well. It needs to stop advertising it. > >

Re: [PATCH v2 net-next 7/9] lan743x: Add EEE support

2018-07-12 Thread Andrew Lunn
> +static int lan743x_ethtool_set_eee(struct net_device *netdev, > +struct ethtool_eee *eee) > +{ > + struct lan743x_adapter *adapter = netdev_priv(netdev); > + struct phy_device *phydev = NULL; > + u32 buf = 0; > + int ret = 0; > + > + if