Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

On Thu, Oct 13, 2016 at 09:43:57AM -0600, David Ahern wrote: > On 10/13/16 1:16 AM, Cyrill Gorcunov wrote: > > On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote: > >> From: Cyrill Gorcunov > >> Date: Wed, 12 Oct 2016 09:53:29 +0300 > >> > >>> I can't rename the

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

On 10/13/16 1:16 AM, Cyrill Gorcunov wrote: > On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote: >> From: Cyrill Gorcunov >> Date: Wed, 12 Oct 2016 09:53:29 +0300 >> >>> I can't rename the field, neither a can use union. >> >> Remind me again what is wrong with

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

On Wed, Oct 12, 2016 at 07:55:04PM -0400, David Miller wrote: > From: Cyrill Gorcunov > Date: Wed, 12 Oct 2016 09:53:29 +0300 > > > I can't rename the field, neither a can use union. > > Remind me again what is wrong with using an anonymous union? Anon union would be a

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

From: Cyrill Gorcunov Date: Wed, 12 Oct 2016 09:53:29 +0300 > I can't rename the field, neither a can use union. Remind me again what is wrong with using an anonymous union?

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

On Wed, Oct 12, 2016 at 01:50:22AM -0400, David Miller wrote: > > Macros that look like function calls and are also lvalues tend to be > troublesome. > > I know what you're trying to achieve, you want a named way to access > this so that the intent and semantics are clear. > > But I'd rather

Re: [PATCH v6] net: ip, diag -- Add diag interface for raw sockets

From: Cyrill Gorcunov Date: Thu, 6 Oct 2016 13:00:55 +0300 > v6: > - use sdiag_raw_protocol() helper which will access @pad >structure used for raw sockets protocol specification: >we can't simply rename this member without breaking uapi. Macros that look like