Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jose Abreu
On 04-09-2018 10:16, Jerome Brunet wrote: > On Mon, 2018-09-03 at 16:47 +0100, Jose Abreu wrote: >> On 03-09-2018 16:38, Jerome Brunet wrote: >>> On Mon, 2018-09-03 at 16:22 +0100, Jose Abreu wrote: On 03-09-2018 15:10, Jerome Brunet wrote: > On Mon, 2018-09-03 at 12:47 +0100, Jose

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-04 Thread Jerome Brunet
On Mon, 2018-09-03 at 16:47 +0100, Jose Abreu wrote: > On 03-09-2018 16:38, Jerome Brunet wrote: > > On Mon, 2018-09-03 at 16:22 +0100, Jose Abreu wrote: > > > On 03-09-2018 15:10, Jerome Brunet wrote: > > > > On Mon, 2018-09-03 at 12:47 +0100, Jose Abreu wrote: > > > > > On 03-09-2018 11:16,

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jose Abreu
On 03-09-2018 16:38, Jerome Brunet wrote: > On Mon, 2018-09-03 at 16:22 +0100, Jose Abreu wrote: >> On 03-09-2018 15:10, Jerome Brunet wrote: >>> On Mon, 2018-09-03 at 12:47 +0100, Jose Abreu wrote: On 03-09-2018 11:16, Jerome Brunet wrote: > No notable change. Rx is fine but Tx: > [

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jerome Brunet
On Mon, 2018-09-03 at 16:22 +0100, Jose Abreu wrote: > On 03-09-2018 15:10, Jerome Brunet wrote: > > On Mon, 2018-09-03 at 12:47 +0100, Jose Abreu wrote: > > > On 03-09-2018 11:16, Jerome Brunet wrote: > > > > No notable change. Rx is fine but Tx: > > > > [ 5] 3.00-4.00 sec 3.55 MBytes 29.8

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jose Abreu
On 03-09-2018 15:10, Jerome Brunet wrote: > On Mon, 2018-09-03 at 12:47 +0100, Jose Abreu wrote: >> On 03-09-2018 11:16, Jerome Brunet wrote: >>> No notable change. Rx is fine but Tx: >>> [ 5] 3.00-4.00 sec 3.55 MBytes 29.8 Mbits/sec 51 12.7 KBytes >>> >>> I suppose the problem as

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jerome Brunet
On Mon, 2018-09-03 at 12:47 +0100, Jose Abreu wrote: > On 03-09-2018 11:16, Jerome Brunet wrote: > > No notable change. Rx is fine but Tx: > > [ 5] 3.00-4.00 sec 3.55 MBytes 29.8 Mbits/sec 51 12.7 KBytes > > > > I suppose the problem as something to do with the retries. When doing Tx

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jose Abreu
On 03-09-2018 11:16, Jerome Brunet wrote: > No notable change. Rx is fine but Tx: > [ 5] 3.00-4.00 sec 3.55 MBytes 29.8 Mbits/sec 51 12.7 KBytes > > I suppose the problem as something to do with the retries. When doing Tx test > alone, we don't have such a things a throughput where we

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jerome Brunet
On Mon, 2018-09-03 at 10:36 +0100, Jose Abreu wrote: > Hi Jerome, > > On 03-09-2018 09:56, Jerome Brunet wrote: > > On Thu, 2018-08-30 at 11:37 +0100, Jose Abreu wrote: > > > [ As for now this is only for testing! ] > > > > > > This follows David Miller advice and tries to fix coalesce timer in

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jose Abreu
Hi Jerome, On 03-09-2018 09:56, Jerome Brunet wrote: > On Thu, 2018-08-30 at 11:37 +0100, Jose Abreu wrote: >> [ As for now this is only for testing! ] >> >> This follows David Miller advice and tries to fix coalesce timer in >> multi-queue scenarios. >> >> We are now using per-queue coalesce

Re: [RFT net-next] net: stmmac: Rework coalesce timer and fix multi-queue races

2018-09-03 Thread Jerome Brunet
On Thu, 2018-08-30 at 11:37 +0100, Jose Abreu wrote: > [ As for now this is only for testing! ] > > This follows David Miller advice and tries to fix coalesce timer in > multi-queue scenarios. > > We are now using per-queue coalesce values and per-queue TX timer. This > assumes that tx_queues ==