Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-21 Thread Jiri Pirko
Wed, Nov 21, 2018 at 05:59:45AM CET, dsah...@gmail.com wrote: >On 11/20/18 9:59 PM, Nambiar, Amritha wrote: >> Oops, submitted the v2 patch for man changes too soon, without seeing >> this. So, in this case, should I re-submit the iproute2-flower patch >> that was accepted removing the 'range'

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-20 Thread Nambiar, Amritha
On 11/20/2018 8:59 PM, David Ahern wrote: > On 11/20/18 9:59 PM, Nambiar, Amritha wrote: >> Oops, submitted the v2 patch for man changes too soon, without seeing >> this. So, in this case, should I re-submit the iproute2-flower patch >> that was accepted removing the 'range' keyword? > > I think

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-20 Thread David Ahern
On 11/20/18 9:59 PM, Nambiar, Amritha wrote: > Oops, submitted the v2 patch for man changes too soon, without seeing > this. So, in this case, should I re-submit the iproute2-flower patch > that was accepted removing the 'range' keyword? I think so. Consistency across commands is a good thing.

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-20 Thread Nambiar, Amritha
On 11/20/2018 8:46 PM, David Ahern wrote: > On 11/20/18 9:44 PM, Nambiar, Amritha wrote: >> On 11/20/2018 2:56 PM, David Ahern wrote: >>> On 11/15/18 5:55 PM, Amritha Nambiar wrote: Add details explaining filtering based on port ranges. Signed-off-by: Amritha Nambiar ---

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-20 Thread David Ahern
On 11/20/18 9:44 PM, Nambiar, Amritha wrote: > On 11/20/2018 2:56 PM, David Ahern wrote: >> On 11/15/18 5:55 PM, Amritha Nambiar wrote: >>> Add details explaining filtering based on port ranges. >>> >>> Signed-off-by: Amritha Nambiar >>> --- >>> man/man8/tc-flower.8 | 12 ++-- >>> 1

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-20 Thread Nambiar, Amritha
On 11/20/2018 2:56 PM, David Ahern wrote: > On 11/15/18 5:55 PM, Amritha Nambiar wrote: >> Add details explaining filtering based on port ranges. >> >> Signed-off-by: Amritha Nambiar >> --- >> man/man8/tc-flower.8 | 12 ++-- >> 1 file changed, 10 insertions(+), 2 deletions(-) >> >>

Re: [iproute2-next PATCH v3 2/2] man: tc-flower: Add explanation for range option

2018-11-20 Thread David Ahern
On 11/15/18 5:55 PM, Amritha Nambiar wrote: > Add details explaining filtering based on port ranges. > > Signed-off-by: Amritha Nambiar > --- > man/man8/tc-flower.8 | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/man/man8/tc-flower.8