Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-30 Thread Mugunthan V N
On Thursday 30 July 2015 04:27 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: [...] cpsw_ndo_stop calls napi_disable: you

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-29 Thread Francois Romieu
Mugunthan V N mugunthan...@ti.com : On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: [...] cpsw_ndo_stop calls napi_disable: you can remove netif_running. This netif_running check is

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Francois Romieu
Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id) struct cpsw_priv *priv = dev_id; cpdma_ctlr_eoi(priv-dma,

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Mugunthan V N
On Wednesday 29 July 2015 04:00 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq, void *dev_id) struct

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Mugunthan V N
On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index d68d759..4f98537 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -752,13

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-28 Thread Mugunthan V N
On Tuesday 28 July 2015 02:52 AM, Francois Romieu wrote: Mugunthan V N mugunthan...@ti.com : [...] diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index d68d759..4f98537 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -752,13

Re: [net-next PATCH 2/2] drivers: net: cpsw: add separate napi for tx packet handling for performance improvment

2015-07-27 Thread Francois Romieu
Mugunthan V N mugunthan...@ti.com : [...] diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index d68d759..4f98537 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -752,13 +753,22 @@ static irqreturn_t cpsw_tx_interrupt(int irq,