Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
On 16-02-25 03:05 PM, Jamal Hadi Salim wrote: > On 16-02-25 04:56 PM, John Fastabend wrote: >> On 16-02-25 04:56 AM, Jamal Hadi Salim wrote: > >> >> decoding that is not a problem. The ixgbe driver code already applied >> can decode that without much trouble. The thing I want to avoid is >>

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread Jamal Hadi Salim
On 16-02-25 04:56 PM, John Fastabend wrote: On 16-02-25 04:56 AM, Jamal Hadi Salim wrote: decoding that is not a problem. The ixgbe driver code already applied can decode that without much trouble. The thing I want to avoid is requiring my driver to do the inverse translation because

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
On 16-02-25 04:56 AM, Jamal Hadi Salim wrote: > On 16-02-24 11:04 PM, John Fastabend wrote: >> On 16-02-24 05:31 AM, Jamal Hadi Salim wrote: > >> I think this is absolutely necessary not only for performance of >> reporting the rules back to software but if we don't do it generically >> the

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread John Fastabend
On 16-02-25 05:19 AM, Jamal Hadi Salim wrote: > On 16-02-24 11:09 PM, John Fastabend wrote: >> On 16-02-24 01:29 AM, Jiri Benc wrote: >>> On Wed, 24 Feb 2016 00:55:55 -0800, John Fastabend wrote: The flags however likely stays with with TCA_U32_FLAGS until there is some better way to

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread Jamal Hadi Salim
On 16-02-24 11:09 PM, John Fastabend wrote: On 16-02-24 01:29 AM, Jiri Benc wrote: On Wed, 24 Feb 2016 00:55:55 -0800, John Fastabend wrote: The flags however likely stays with with TCA_U32_FLAGS until there is some better way to group common attributes in 'tc' framework. That's pretty bad,

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-25 Thread Jamal Hadi Salim
On 16-02-24 11:04 PM, John Fastabend wrote: On 16-02-24 05:31 AM, Jamal Hadi Salim wrote: I think this is absolutely necessary not only for performance of reporting the rules back to software but if we don't do it generically the driver will have to do it anyways because doing the inverse

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread John Fastabend
On 16-02-24 01:29 AM, Jiri Benc wrote: > On Wed, 24 Feb 2016 00:55:55 -0800, John Fastabend wrote: >> The flags however likely stays with with TCA_U32_FLAGS until there is >> some better way to group common attributes in 'tc' framework. > > That's pretty bad, as this is uAPI and will need to be

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread John Fastabend
On 16-02-24 05:31 AM, Jamal Hadi Salim wrote: > On 16-02-23 02:03 PM, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on an end host

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread Jamal Hadi Salim
On 16-02-23 02:03 PM, John Fastabend wrote: In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the hardware

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread Jiri Benc
On Wed, 24 Feb 2016 00:55:55 -0800, John Fastabend wrote: > The flags however likely stays with with TCA_U32_FLAGS until there is > some better way to group common attributes in 'tc' framework. That's pretty bad, as this is uAPI and will need to be supported forever. And having a different

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread John Fastabend
On 16-02-24 12:40 AM, Jiri Pirko wrote: > Wed, Feb 24, 2016 at 09:04:40AM CET, a...@vadai.me wrote: >> On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: >>> In the initial implementation the only way to stop a rule from being >>> inserted into the hardware table was via the device

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread Jiri Pirko
Wed, Feb 24, 2016 at 09:04:40AM CET, a...@vadai.me wrote: >On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-24 Thread Amir Vadai"
On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: > In the initial implementation the only way to stop a rule from being > inserted into the hardware table was via the device feature flag. > However this doesn't work well when working on an end host system > where packets are expect

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread John Fastabend
On 16-02-23 10:11 PM, Simon Horman wrote: > On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread Simon Horman
On Tue, Feb 23, 2016 at 11:03:21AM -0800, John Fastabend wrote: > In the initial implementation the only way to stop a rule from being > inserted into the hardware table was via the device feature flag. > However this doesn't work well when working on an end host system > where packets are expect

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread John Fastabend
On 16-02-23 02:29 PM, Samudrala, Sridhar wrote: > > > On 2/23/2016 11:03 AM, John Fastabend wrote: >> In the initial implementation the only way to stop a rule from being >> inserted into the hardware table was via the device feature flag. >> However this doesn't work well when working on an end

Re: [net-next PATCH 3/4] net: sched: cls_u32 add bit to specify software only rules

2016-02-23 Thread Samudrala, Sridhar
On 2/23/2016 11:03 AM, John Fastabend wrote: In the initial implementation the only way to stop a rule from being inserted into the hardware table was via the device feature flag. However this doesn't work well when working on an end host system where packets are expect to hit both the