Re: [patch net-next 11/17] ipv6: fib: Allow non-FIB users to take reference on route

2017-07-19 Thread David Ahern
On 7/19/17 10:17 AM, Ido Schimmel wrote: > I did exactly that in the beginning, but it didn't sit right with me for > the exact reason you mentioned - it can be a PITA to debug. > > If we use rt6i_ref for something other than FIB references, then it > breaks existing code that relies on rt6i_ref

Re: [patch net-next 11/17] ipv6: fib: Allow non-FIB users to take reference on route

2017-07-19 Thread Ido Schimmel
On Wed, Jul 19, 2017 at 09:49:37AM -0600, David Ahern wrote: > On 7/19/17 1:02 AM, Jiri Pirko wrote: > > From: Ido Schimmel > > > > Listeners of the FIB notification chain are expected to be able to take > > and release a reference on notified IPv6 routes. This is needed in

Re: [patch net-next 11/17] ipv6: fib: Allow non-FIB users to take reference on route

2017-07-19 Thread David Ahern
On 7/19/17 1:02 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Listeners of the FIB notification chain are expected to be able to take > and release a reference on notified IPv6 routes. This is needed in the > case of drivers capable of offloading these routes to a capable