Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

2017-07-19 Thread Ido Schimmel
On Wed, Jul 19, 2017 at 10:36:52AM -0600, David Ahern wrote: > >> 2. How are routes with devices unrelated to ports owned by this driver > >> handled? > > > > They are handled just like any other route, but they don't have a valid > > RIF (for directly connected routes) or an adjacency group (for

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

2017-07-19 Thread David Ahern
On 7/19/17 10:30 AM, Ido Schimmel wrote: >> rif == 0 means the dst device is not related to a port owned by this >> driver? > > Yes. > >> >> >> A lot to process so I am sure I missed the answer to these: >> >> 1. How do you handle host routes for local addresses? IPv6 inserts the >> host and

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

2017-07-19 Thread Ido Schimmel
On Wed, Jul 19, 2017 at 10:14:54AM -0600, David Ahern wrote: > On 7/19/17 1:02 AM, Jiri Pirko wrote: > > @@ -2094,6 +2106,40 @@ mlxsw_sp_fib_entry_should_offload(const struct > > mlxsw_sp_fib_entry *fib_entry) > > } > > } > > > > +static void > > +mlxsw_sp_fib6_entry_offload_set(struct

Re: [patch net-next 14/17] mlxsw: spectrum_router: Add support for IPv6 routes addition / deletion

2017-07-19 Thread David Ahern
On 7/19/17 1:02 AM, Jiri Pirko wrote: > @@ -2094,6 +2106,40 @@ mlxsw_sp_fib_entry_should_offload(const struct > mlxsw_sp_fib_entry *fib_entry) > } > } > > +static void > +mlxsw_sp_fib6_entry_offload_set(struct mlxsw_sp_fib_entry *fib_entry) > +{ > + struct mlxsw_sp_fib6_entry