Re: [patch net-next RFC 0/4] net: sched: allow qdiscs to share filter block instances

2017-07-14 Thread Jamal Hadi Salim
On 17-07-11 08:34 AM, Jiri Pirko wrote: Tue, Jul 11, 2017 at 02:15:27PM CEST, j...@mojatatu.com wrote: Hi Jiri, [..] Now we can add filter to any of qdiscs sharing the same block: $ tc filter add dev ens7 parent : protocol ip pref 25 flower dst_ip 192.168.0.0/16 action drop So for

Re: [patch net-next RFC 0/4] net: sched: allow qdiscs to share filter block instances

2017-07-11 Thread Jiri Pirko
Tue, Jul 11, 2017 at 02:15:27PM CEST, j...@mojatatu.com wrote: >Hi Jiri, > >Commenting on generalities - will comment on code later: > >On 17-07-10 02:51 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the filters added to qdiscs are independent. So for example if

Re: [patch net-next RFC 0/4] net: sched: allow qdiscs to share filter block instances

2017-07-11 Thread Jamal Hadi Salim
Hi Jiri, Commenting on generalities - will comment on code later: On 17-07-10 02:51 PM, Jiri Pirko wrote: From: Jiri Pirko Currently the filters added to qdiscs are independent. So for example if you have 2 netdevices and you create ingress qdisc on both and you want to

Re: [patch net-next RFC 0/4] net: sched: allow qdiscs to share filter block instances

2017-07-11 Thread Jiri Pirko
Tue, Jul 11, 2017 at 08:57:30AM CEST, gerlitz...@gmail.com wrote: >On Mon, Jul 10, 2017 at 9:51 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the filters added to qdiscs are independent. So for example if you >> have 2 netdevices and you create

Re: [patch net-next RFC 0/4] net: sched: allow qdiscs to share filter block instances

2017-07-11 Thread Or Gerlitz
On Mon, Jul 10, 2017 at 9:51 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently the filters added to qdiscs are independent. So for example if you > have 2 netdevices and you create ingress qdisc on both and you want to add > identical filter rules both,