Re: [patch net-next repost 1/3] idr: Use unsigned long instead of int

2017-08-16 Thread Jiri Pirko
Wed, Aug 16, 2017 at 04:57:18PM CEST, eric.duma...@gmail.com wrote: >On Wed, 2017-08-16 at 13:06 +0200, Jiri Pirko wrote: >> Wed, Aug 16, 2017 at 12:58:53PM CEST, eric.duma...@gmail.com wrote: >> >On Wed, 2017-08-16 at 12:53 +0200, Jiri Pirko wrote: >> > >> >> rhashtable is unnecesary big hammer

Re: [patch net-next repost 1/3] idr: Use unsigned long instead of int

2017-08-16 Thread Eric Dumazet
On Wed, 2017-08-16 at 13:06 +0200, Jiri Pirko wrote: > Wed, Aug 16, 2017 at 12:58:53PM CEST, eric.duma...@gmail.com wrote: > >On Wed, 2017-08-16 at 12:53 +0200, Jiri Pirko wrote: > > > >> rhashtable is unnecesary big hammer for this. IDR is nice fit for > >> this purpose. > > > >Obviously IDR does

Re: [patch net-next repost 1/3] idr: Use unsigned long instead of int

2017-08-16 Thread Jiri Pirko
Wed, Aug 16, 2017 at 12:58:53PM CEST, eric.duma...@gmail.com wrote: >On Wed, 2017-08-16 at 12:53 +0200, Jiri Pirko wrote: > >> rhashtable is unnecesary big hammer for this. IDR is nice fit for >> this purpose. > >Obviously IDR does not fit, since you have to change its ABI. I don't think it is a

Re: [patch net-next repost 1/3] idr: Use unsigned long instead of int

2017-08-16 Thread Eric Dumazet
On Wed, 2017-08-16 at 12:53 +0200, Jiri Pirko wrote: > rhashtable is unnecesary big hammer for this. IDR is nice fit for > this purpose. Obviously IDR does not fit, since you have to change its ABI. If rhashtable does not fit this, then I wonder why we spent so many days of work adding it in

Re: [patch net-next repost 1/3] idr: Use unsigned long instead of int

2017-08-16 Thread Jiri Pirko
Wed, Aug 16, 2017 at 12:37:09PM CEST, eric.duma...@gmail.com wrote: >On Wed, 2017-08-16 at 04:14 -0400, Chris Mi wrote: >> IDR uses internally radix tree which uses unsigned long. It doesn't >> makes sense to have index as signed value. >> >> Signed-off-by: Chris Mi >>

Re: [patch net-next repost 1/3] idr: Use unsigned long instead of int

2017-08-16 Thread Eric Dumazet
On Wed, 2017-08-16 at 04:14 -0400, Chris Mi wrote: > IDR uses internally radix tree which uses unsigned long. It doesn't > makes sense to have index as signed value. > > Signed-off-by: Chris Mi > Signed-off-by: Jiri Pirko > --- > block/bsg.c