Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-08 Thread Marcelo Ricardo Leitner
On Mon, Jan 08, 2018 at 04:42:03PM +0100, Jiri Pirko wrote: > Mon, Jan 08, 2018 at 04:23:06PM CET, marcelo.leit...@gmail.com wrote: > >On Sat, Jan 06, 2018 at 12:09:18AM +0100, Jiri Pirko wrote: > >... > >> Note we cannot use the qdisc for filter manipulations for shared blocks: > >> > >> $ tc fil

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-08 Thread Jiri Pirko
Mon, Jan 08, 2018 at 04:23:06PM CET, marcelo.leit...@gmail.com wrote: >On Sat, Jan 06, 2018 at 12:09:18AM +0100, Jiri Pirko wrote: >... >> Note we cannot use the qdisc for filter manipulations for shared blocks: >> >> $ tc filter add dev ens8 ingress protocol ip pref 1 flower dst_ip >> 192.168.10

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-08 Thread Marcelo Ricardo Leitner
On Sat, Jan 06, 2018 at 12:09:18AM +0100, Jiri Pirko wrote: ... > Note we cannot use the qdisc for filter manipulations for shared blocks: > > $ tc filter add dev ens8 ingress protocol ip pref 1 flower dst_ip > 192.168.100.2 action drop > Error: Cannot work with shared block, please use block ind

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jiri Pirko
Sat, Jan 06, 2018 at 07:16:10PM CET, j...@mojatatu.com wrote: >On 18-01-06 12:41 PM, David Ahern wrote: >> On 1/6/18 1:07 AM, Jiri Pirko wrote: >> > Sat, Jan 06, 2018 at 04:57:21AM CET, dsah...@gmail.com wrote: >> > > On 1/5/18 4:09 PM, Jiri Pirko wrote: >> > > > From: Jiri Pirko >> > > > > >> >

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jiri Pirko
Sat, Jan 06, 2018 at 06:41:18PM CET, dsah...@gmail.com wrote: >On 1/6/18 1:07 AM, Jiri Pirko wrote: >> Sat, Jan 06, 2018 at 04:57:21AM CET, dsah...@gmail.com wrote: >>> On 1/5/18 4:09 PM, Jiri Pirko wrote: From: Jiri Pirko Currently the filters added to qdiscs are independent. So fo

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread David Ahern
On 1/6/18 11:02 AM, Jamal Hadi Salim wrote: > BTW: From your output, DavidA, i noticed something strange: > two flower filters with the same handle id 0x1 (different prios) > and also two filters with the same prio (but different handles). > I see one was added using :dev .." - how were the other 2

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jamal Hadi Salim
On 18-01-06 01:02 PM, Jamal Hadi Salim wrote: On 18-01-06 04:48 AM, Jiri Pirko wrote: BTW: From your output, DavidA, i noticed something strange: two flower filters with the same handle id 0x1 (different prios) At least on the kernel i am using this is the exhibited default behavior. I can

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jamal Hadi Salim
On 18-01-06 12:41 PM, David Ahern wrote: On 1/6/18 1:07 AM, Jiri Pirko wrote: Sat, Jan 06, 2018 at 04:57:21AM CET, dsah...@gmail.com wrote: On 1/5/18 4:09 PM, Jiri Pirko wrote: From: Jiri Pirko $ tc filter show block 22 $ echo $? 0 $ tc qdisc show | grep block qdisc ingress : dev et

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jamal Hadi Salim
On 18-01-06 04:48 AM, Jiri Pirko wrote: [..] Or, do you think it should work like: $ tc qdisc add dev ens8 ingress $ tc qdisc qdisc ingress : dev ens8 parent :fff1 > $ tc qdisc add dev ens7 ingress block 22 > $ tc qdisc qdisc ingress : dev ens7 parent :fff1 block 22 qdisc

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread David Ahern
On 1/6/18 1:07 AM, Jiri Pirko wrote: > Sat, Jan 06, 2018 at 04:57:21AM CET, dsah...@gmail.com wrote: >> On 1/5/18 4:09 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Currently the filters added to qdiscs are independent. So for example if you >>> have 2 netdevices and you create ingress qdisc

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jiri Pirko
Sat, Jan 06, 2018 at 09:07:28AM CET, j...@resnulli.us wrote: >Sat, Jan 06, 2018 at 04:57:21AM CET, dsah...@gmail.com wrote: >>On 1/5/18 4:09 PM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Currently the filters added to qdiscs are independent. So for example if you >>> have 2 netdevices and yo

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-06 Thread Jiri Pirko
Sat, Jan 06, 2018 at 04:57:21AM CET, dsah...@gmail.com wrote: >On 1/5/18 4:09 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently the filters added to qdiscs are independent. So for example if you >> have 2 netdevices and you create ingress qdisc on both and you want to add >> identical fil

Re: [patch net-next v6 00/11] net: sched: allow qdiscs to share filter block instances

2018-01-05 Thread David Ahern
On 1/5/18 4:09 PM, Jiri Pirko wrote: > From: Jiri Pirko > > Currently the filters added to qdiscs are independent. So for example if you > have 2 netdevices and you create ingress qdisc on both and you want to add > identical filter rules both, you need to add them twice. This patchset > makes th