Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-26 Thread Herbert Xu
On Mon, May 25, 2015 at 07:53:41PM +0800, Herbert Xu wrote: On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote: When you have my code local, simply execute libkcapi/test/kcapi -y twice or three times. That triggered the crash. Aha that's what I was missing. I'll look into

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-26 Thread Stephan Mueller
Am Dienstag, 26. Mai 2015, 14:24:33 schrieb Herbert Xu: Hi Herbert, On Mon, May 25, 2015 at 07:53:41PM +0800, Herbert Xu wrote: On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote: When you have my code local, simply execute libkcapi/test/kcapi -y twice or three times.

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-26 Thread Herbert Xu
On Tue, May 26, 2015 at 08:44:29AM +0200, Stephan Mueller wrote: Confirmed. I see no more issues on the AF_ALG side. OK it works but there is a more serious issue. In particular, the user-space interface only provides spaces for the AD in the source and not in the destination. That means if

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-26 Thread Stephan Mueller
Am Dienstag, 26. Mai 2015, 15:36:05 schrieb Herbert Xu: Hi Herbert, In order to allow this to be done I'm going to disable the AEAD user-space interface in 4.1 so that we have time to fix it properly for 4.2. Ok. Would you look into that one or shall I do that? Ciao Stephan -- To unsubscribe

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-26 Thread Herbert Xu
On Tue, May 26, 2015 at 09:57:51AM +0200, Stephan Mueller wrote: Ok. Would you look into that one or shall I do that? I'll reenable it immediately after the patch to convert it to the new interface is merged. Cheers, -- Email: Herbert Xu herb...@gondor.apana.org.au Home Page:

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-25 Thread Herbert Xu
On Sun, May 24, 2015 at 12:52:02PM +0200, Stephan Mueller wrote: [ 29.653113] BUG: unable to handle kernel NULL pointer dereference at 000c Weird. I tried running your test but it appears to pass. The only failures were the nonsense strings and everything else says pased. It

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-25 Thread Herbert Xu
On Mon, May 25, 2015 at 01:50:55PM +0200, Stephan Mueller wrote: When you have my code local, simply execute libkcapi/test/kcapi -y twice or three times. That triggered the crash. Aha that's what I was missing. I'll look into the crash. Thanks, -- Email: Herbert Xu

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-25 Thread Stephan Mueller
Am Montag, 25. Mai 2015, 18:20:21 schrieb Herbert Xu: Hi Herbert, On Sun, May 24, 2015 at 12:52:02PM +0200, Stephan Mueller wrote: [ 29.653113] BUG: unable to handle kernel NULL pointer dereference at 000c Weird. I tried running your test but it appears to pass. The only

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-24 Thread Stephan Mueller
Am Sonntag, 24. Mai 2015, 11:34:20 schrieb Herbert Xu: Hi Herbert, On Sat, May 23, 2015 at 08:04:19PM +0200, Stephan Mueller wrote: Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-23 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. After applying your additional patch, the normal AEAD operation works. But with long messages (16

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-23 Thread Stephan Mueller
Am Samstag, 23. Mai 2015, 05:58:18 schrieb Herbert Xu: Hi Herbert, On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote: Note, gcm(aes) looks good. Only rfc4106(gcm(aes)) causes the crash. Actually it looks like the culprit hasn't been merged yet so I'll just respin the series.

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-23 Thread Herbert Xu
On Sat, May 23, 2015 at 08:04:19PM +0200, Stephan Mueller wrote: Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. After applying your

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Herbert Xu
On Fri, May 22, 2015 at 11:04:39PM +0200, Stephan Mueller wrote: Note, gcm(aes) looks good. Only rfc4106(gcm(aes)) causes the crash. Actually it looks like the culprit hasn't been merged yet so I'll just respin the series. Anyway, this patch should fix your crash: diff --git

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Using an up-to date tree with the full set of patches of this patch set, I get the following

Re: [v2 PATCH 13/13] crypto: algif_aead - Switch to new AEAD interface

2015-05-22 Thread Stephan Mueller
Am Freitag, 22. Mai 2015, 22:59:34 schrieb Stephan Mueller: Hi Stephan, Am Freitag, 22. Mai 2015, 16:31:04 schrieb Herbert Xu: Hi Herbert, This patch makes use of the new AEAD interface which uses a single SG list instead of separate lists for the AD and plain text. Using an up-to