Re: Microsemi VSC 8531/41 PHY Driver

2016-08-16 Thread Andrew Lunn
On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote: > Hello, > > I added all review comments and re-sending for review. You should also take a look at the output of scripts/checkpatch.pl: total: 9 errors, 82 warnings, 1 checks, 179 lines checked Andrew

Re: Microsemi VSC 8531/41 PHY Driver

2016-08-16 Thread Andrew Lunn
On Fri, Aug 05, 2016 at 05:54:21PM +0530, Nagaraju Lakkaraju wrote: > Hello, > > I added all review comments and re-sending for review. > > >From a5017f5878a92d2acec86a6a29b1498c457cb73a Mon Sep 17 00:00:00 2001 > From: Nagaraju Lakkaraju > Date: Wed, 3 Aug 2016

Re: Microsemi VSC 8531/41 PHY Driver

2016-08-05 Thread Nagaraju Lakkaraju
Hello, I added all review comments and re-sending for review. >From a5017f5878a92d2acec86a6a29b1498c457cb73a Mon Sep 17 00:00:00 2001 From: Nagaraju Lakkaraju Date: Wed, 3 Aug 2016 18:28:24 +0530 Subject: [PATCH v2] net: phy: Add drivers for Microsemi PHYs

Re: Microsemi VSC 8531/41 PHY Driver

2016-08-04 Thread Nagaraju Lakkaraju
On Fri, Jul 29, 2016 at 10:17:36AM +0200, Andrew Lunn wrote: > EXTERNAL EMAIL > > > > > +/* RGMII Rx Clock delay value change with board lay-out */ static u8 > > > +rgmii_rx_clk_delay = RGMII_RX_CLK_DELAY_1_1_NS; > > > > Doesn't this stop you from having a board with two PHYs with different > >

Re: Microsemi VSC 8531/41 PHY Driver

2016-08-04 Thread Nagaraju Lakkaraju
; Thanks, > > Raju > > > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Tuesday, July 26, 2016 6:14 PM > > To: Raju Lakkaraju > > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Allan Nielsen > > Subject: Re: Mic

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-29 Thread Andrew Lunn
> > +/* RGMII Rx Clock delay value change with board lay-out */ static u8 > > +rgmii_rx_clk_delay = RGMII_RX_CLK_DELAY_1_1_NS; > > Doesn't this stop you from having a board with two PHYs with different > layouts? You should be getting this value from the device tree. > > Raju: As of now, RGMII

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-29 Thread Andrew Lunn
t: Tuesday, July 26, 2016 6:14 PM > To: Raju Lakkaraju > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Allan Nielsen > Subject: Re: Microsemi VSC 8531/41 PHY Driver > > EXTERNAL EMAIL > > > > +/* RGMII Rx Clock delay value change with board lay-out */ st

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-28 Thread Florian Fainelli
July 26, 2016 6:14 PM > To: Raju Lakkaraju > Cc: netdev@vger.kernel.org; f.faine...@gmail.com; Allan Nielsen > Subject: Re: Microsemi VSC 8531/41 PHY Driver > > EXTERNAL EMAIL > > >> +/* RGMII Rx Clock delay value change with board lay-out */ static u8 >> +rgmii_rx_clk_

RE: Microsemi VSC 8531/41 PHY Driver

2016-07-28 Thread Raju Lakkaraju
Subject: Re: Microsemi VSC 8531/41 PHY Driver EXTERNAL EMAIL > +/* RGMII Rx Clock delay value change with board lay-out */ static u8 > +rgmii_rx_clk_delay = RGMII_RX_CLK_DELAY_1_1_NS; Doesn't this stop you from having a board with two PHYs with different layouts? You should be getting this

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-26 Thread Andrew Lunn
> +/* RGMII Rx Clock delay value change with board lay-out */ > +static u8 rgmii_rx_clk_delay = RGMII_RX_CLK_DELAY_1_1_NS; Doesn't this stop you from having a board with two PHYs with different layouts? You should be getting this value from the device tree. > + phydev->supported =

RE: Microsemi VSC 8531/41 PHY Driver

2016-07-26 Thread Raju Lakkaraju
"); -- 2.7.3 Thanks and regards, Raju (Nagaraju Lakkaraju) Sr. Staff Engg. Microsemi Communications India Pvt Ltd. Ph: +91 040 6686 0132 -Original Message- From: Andrew Lunn [mailto:and...@lunn.ch] Sent: Tuesday, July 26, 2016 5:26 PM To: Raju Lakkaraju Cc: netdev@vger.kernel.org;

Re: Microsemi VSC 8531/41 PHY Driver

2016-07-26 Thread Andrew Lunn
On Tue, Jul 26, 2016 at 09:49:53AM +, Raju Lakkaraju wrote: > Hello All, > > I would like to introduce myself as Nagaraju Lakkaraju (Raju), is working in > Microsemi Communications India Pvt. Ltd (Formerly known as Vitesse > Semiconductors Limited) - Hyderabad as Sr. Staff Engineer. > I do