Re: Requirements for a shutdown function?

2017-05-10 Thread Florian Fainelli
On 05/10/2017 03:11 PM, Timur Tabi wrote: > On 05/10/2017 04:47 PM, Florian Fainelli wrote: >> AFAIR kexec takes care of shutting down network devices explicitly >> (unless instructed otherwise with -x/--no-ifdown) so this may be where >> this is coming from. >> >> Reading through

Re: Requirements for a shutdown function?

2017-05-10 Thread Timur Tabi
On 05/10/2017 04:47 PM, Florian Fainelli wrote: > AFAIR kexec takes care of shutting down network devices explicitly > (unless instructed otherwise with -x/--no-ifdown) so this may be where > this is coming from. > > Reading through drivers/base/core.c it does not appear that ->remove() > is

Re: Requirements for a shutdown function?

2017-05-10 Thread Florian Fainelli
On 05/10/2017 01:17 PM, Timur Tabi wrote: > On 05/09/2017 02:06 PM, Florian Fainelli wrote: >> On 05/09/2017 11:51 AM, Timur Tabi wrote: > >>> Is it possible that the network stack detects a kexec and automatically >>> stops all network devices? >> >> No. why would it? However the device driver

Re: Requirements for a shutdown function?

2017-05-10 Thread Timur Tabi
On 05/09/2017 02:06 PM, Florian Fainelli wrote: > On 05/09/2017 11:51 AM, Timur Tabi wrote: >> Is it possible that the network stack detects a kexec and automatically >> stops all network devices? > > No. why would it? However the device driver model does call into your > driver's remove

Re: Requirements for a shutdown function?

2017-05-09 Thread Florian Fainelli
On 05/09/2017 11:51 AM, Timur Tabi wrote: > On 05/09/2017 01:46 PM, Florian Fainelli wrote: >> A good test case for exercising a .shutdown() function is kexec'ing a >> new kernel for instance. > > I tried that. I run iperf in one window while launching kexec in another. > Even without a shutdown

Re: Requirements for a shutdown function?

2017-05-09 Thread Timur Tabi
On 05/09/2017 01:46 PM, Florian Fainelli wrote: > A good test case for exercising a .shutdown() function is kexec'ing a > new kernel for instance. I tried that. I run iperf in one window while launching kexec in another. Even without a shutdown function, network traffic appear to halt on its own

Re: Requirements for a shutdown function?

2017-05-09 Thread Florian Fainelli
On 05/09/2017 09:58 AM, Timur Tabi wrote: > I'm trying to add a platform_driver.shutdown function to my Ethernet driver > (drivers/net/ethernet/qualcomm/emac/*), but I can't find any definitive > information as to what a network driver shutdown callback is supposed to do. > I also don't know what