Re: Synopsys Ethernet QoS Driver

2016-12-07 Thread Andy Shevchenko
On Mon, Nov 21, 2016 at 2:52 PM, Giuseppe CAVALLARO wrote: First of all, +1 to (re-)use stmmac. > The stmmac drivers run since many years on several platforms > (sh4, stm32, arm, x86, mips ...) and it supports an huge of amount of > configurations starting from 3.1x to

Re: Synopsys Ethernet QoS Driver

2016-12-07 Thread Pavel Machek
Hi! > > Thanks! > > Regarding this subject, I am thinking of making the following adaption: > > a) delete ethernet/synopsys > b) rename ethernet/stmicro/stmmac to ethernet/synopsys > > and send you a patch for you to evaluate. Both agree with the approach? > To have a new work base would be

Re: Synopsys Ethernet QoS Driver

2016-11-25 Thread Giuseppe CAVALLARO
On 11/23/2016 12:43 PM, Joao Pinto wrote: > Rabin Vincent can review and test that the port works properly on our Artpec-chips that use dwc_eth_qos.c today. > > The main porting step is to implement the device tree binding in bindings/net/snps,dwc-qos-ethernet.txt. Also our chip has a strict

Re: Synopsys Ethernet QoS Driver

2016-11-23 Thread Joao Pinto
On 23-11-2016 11:41, Lars Persson wrote: > >> 23 nov. 2016 kl. 12:11 skrev Joao Pinto : >> >> Hi Peppe and Lars, >> >>> On 23-11-2016 10:59, Giuseppe CAVALLARO wrote: >>> Hello Joao, Lars. >>> On 11/22/2016 3:16 PM, Joao Pinto wrote: >> Ok, it makes sense. >>

Re: Synopsys Ethernet QoS Driver

2016-11-23 Thread Lars Persson
> 23 nov. 2016 kl. 12:11 skrev Joao Pinto : > > Hi Peppe and Lars, > >> On 23-11-2016 10:59, Giuseppe CAVALLARO wrote: >> Hello Joao, Lars. >> >>> On 11/22/2016 3:16 PM, Joao Pinto wrote: > Ok, it makes sense. > Just for curiosity the target setup is the

Re: Synopsys Ethernet QoS Driver

2016-11-23 Thread Joao Pinto
Hi Peppe and Lars, On 23-11-2016 10:59, Giuseppe CAVALLARO wrote: > Hello Joao, Lars. > > On 11/22/2016 3:16 PM, Joao Pinto wrote: >>> Ok, it makes sense. >>> > Just for curiosity the target setup is the following: >>> > https://www.youtube.com/watch?v=8V-LB5y2Cos >>> > but instead of using

Re: Synopsys Ethernet QoS Driver

2016-11-23 Thread Giuseppe CAVALLARO
Hello Joao, Lars. On 11/22/2016 3:16 PM, Joao Pinto wrote: Ok, it makes sense. > Just for curiosity the target setup is the following: > https://www.youtube.com/watch?v=8V-LB5y2Cos > but instead of using internal drivers, we desire to use mainline drivers only. > > Thanks! Regarding this

Re: Synopsys Ethernet QoS Driver

2016-11-23 Thread Giuseppe CAVALLARO
Hello Ozgur On 11/22/2016 9:38 AM, Ozgur Karatas wrote: Hello all, I think, ethtool and mdio don't work because the tool's not support to "QoS", right? Maybe, need a new API. I'm looking for dwceqos code but "tc" tools is very idea. I hope to be me always helpful. tools work but indeed

Re: Synopsys Ethernet QoS Driver

2016-11-22 Thread Joao Pinto
Hi Lars and Peppe, On 21-11-2016 16:11, Joao Pinto wrote: > On 21-11-2016 15:43, Lars Persson wrote: >> >> >>> 21 nov. 2016 kl. 16:06 skrev Joao Pinto : >>> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: > On 11/21/2016 2:28 PM, Lars Persson wrote: > >

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Joao Pinto
On 21-11-2016 15:43, Lars Persson wrote: > > >> 21 nov. 2016 kl. 16:06 skrev Joao Pinto : >> >>> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: On 11/21/2016 2:28 PM, Lars Persson wrote: > 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Lars Persson
> 21 nov. 2016 kl. 16:06 skrev Joao Pinto : > >> On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: >>> On 11/21/2016 2:28 PM, Lars Persson wrote: >>> >>> 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO : Hello Joao > On

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Joao Pinto
On 21-11-2016 15:03, Giuseppe CAVALLARO wrote: > On 11/21/2016 4:00 PM, Joao Pinto wrote: >> On 21-11-2016 14:36, Giuseppe CAVALLARO wrote: >>> Hello Joao >>> >>> On 11/21/2016 2:48 PM, Joao Pinto wrote: Synopsys QoS IP is a separated hardware component, so it should be reusable by

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Joao Pinto
On 21-11-2016 14:36, Giuseppe CAVALLARO wrote: > Hello Joao > > On 11/21/2016 2:48 PM, Joao Pinto wrote: >> Synopsys QoS IP is a separated hardware component, so it should be reusable >> by >> all implementations using it and so have its own "core driver" and platform + >> pci glue drivers. This

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Joao Pinto
On 21-11-2016 14:25, Giuseppe CAVALLARO wrote: > On 11/21/2016 2:28 PM, Lars Persson wrote: >> >> >>> 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO : >>> >>> Hello Joao >>> On 11/21/2016 1:32 PM, Joao Pinto wrote: Hello, > On 21-11-2016 05:29, Rayagond

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Giuseppe CAVALLARO
On 11/21/2016 4:00 PM, Joao Pinto wrote: On 21-11-2016 14:36, Giuseppe CAVALLARO wrote: Hello Joao On 11/21/2016 2:48 PM, Joao Pinto wrote: Synopsys QoS IP is a separated hardware component, so it should be reusable by all implementations using it and so have its own "core driver" and

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Giuseppe CAVALLARO
Hello Joao On 11/21/2016 2:48 PM, Joao Pinto wrote: Synopsys QoS IP is a separated hardware component, so it should be reusable by all implementations using it and so have its own "core driver" and platform + pci glue drivers. This is necessary for example in hardware validation, where you

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Giuseppe CAVALLARO
On 11/21/2016 2:28 PM, Lars Persson wrote: 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO : Hello Joao On 11/21/2016 1:32 PM, Joao Pinto wrote: Hello, On 21-11-2016 05:29, Rayagond Kokatanur wrote: On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Joao Pinto
Hello Peppe, On 21-11-2016 12:52, Giuseppe CAVALLARO wrote: > Hello Joao > > On 11/21/2016 1:32 PM, Joao Pinto wrote: >> Hello, >> >> On 21-11-2016 05:29, Rayagond Kokatanur wrote: >>> On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: On Fri, Nov 18, 2016 at 02:20:27PM

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Lars Persson
> 21 nov. 2016 kl. 13:53 skrev Giuseppe CAVALLARO : > > Hello Joao > >> On 11/21/2016 1:32 PM, Joao Pinto wrote: >> Hello, >> >>> On 21-11-2016 05:29, Rayagond Kokatanur wrote: On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: > On Fri, Nov

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Giuseppe CAVALLARO
Hello Joao On 11/21/2016 1:32 PM, Joao Pinto wrote: Hello, On 21-11-2016 05:29, Rayagond Kokatanur wrote: On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: On Fri, Nov 18, 2016 at 02:20:27PM +, Joao Pinto wrote: For now we are interesting in improving the synopsys QoS

Re: Synopsys Ethernet QoS Driver

2016-11-21 Thread Joao Pinto
Hello, On 21-11-2016 05:29, Rayagond Kokatanur wrote: > On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: >> On Fri, Nov 18, 2016 at 02:20:27PM +, Joao Pinto wrote: >>> For now we are interesting in improving the synopsys QoS driver under >>> /nect/ethernet/synopsys. For

Re: Synopsys Ethernet QoS Driver

2016-11-20 Thread Rayagond Kokatanur
On Sat, Nov 19, 2016 at 7:26 PM, Rabin Vincent wrote: > On Fri, Nov 18, 2016 at 02:20:27PM +, Joao Pinto wrote: >> For now we are interesting in improving the synopsys QoS driver under >> /nect/ethernet/synopsys. For now the driver structure consists of a single >> file >>

Re: Synopsys Ethernet QoS Driver

2016-11-19 Thread Rabin Vincent
On Fri, Nov 18, 2016 at 02:20:27PM +, Joao Pinto wrote: > For now we are interesting in improving the synopsys QoS driver under > /nect/ethernet/synopsys. For now the driver structure consists of a single > file > called dwc_eth_qos.c, containing synopsys ethernet qos common ops and platform

Re: Synopsys Ethernet QoS Driver

2016-11-18 Thread Eric Dumazet
On Fri, 2016-11-18 at 16:40 +, Joao Pinto wrote: > help a lot, thank you! > lets start working then :) Please read this very useful document first, so that you can avoid common mistakes ;) https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt Thanks

Re: Synopsys Ethernet QoS Driver

2016-11-18 Thread Joao Pinto
On 18-11-2016 16:35, Florian Fainelli wrote: > > > On 11/18/2016 08:31 AM, Joao Pinto wrote: >> Hi Florian, >> >> On 18-11-2016 14:53, Florian Fainelli wrote: >>> On November 18, 2016 4:28:30 AM PST, Joao Pinto >>> wrote: snip (...) I would also gladly be

Re: Synopsys Ethernet QoS Driver

2016-11-18 Thread Florian Fainelli
On 11/18/2016 08:31 AM, Joao Pinto wrote: > Hi Florian, > > On 18-11-2016 14:53, Florian Fainelli wrote: >> On November 18, 2016 4:28:30 AM PST, Joao Pinto >> wrote: >>> >>> Dear all, >>> >>> My name is Joao Pinto and I work at Synopsys. >>> I am a kernel developer

Re: Synopsys Ethernet QoS Driver

2016-11-18 Thread Joao Pinto
Hi Florian, On 18-11-2016 14:53, Florian Fainelli wrote: > On November 18, 2016 4:28:30 AM PST, Joao Pinto > wrote: >> >> Dear all, >> >> My name is Joao Pinto and I work at Synopsys. >> I am a kernel developer with special focus in mainline collaboration, >> both

Re: Synopsys Ethernet QoS Driver

2016-11-18 Thread Florian Fainelli
On November 18, 2016 4:28:30 AM PST, Joao Pinto wrote: > >Dear all, > >My name is Joao Pinto and I work at Synopsys. >I am a kernel developer with special focus in mainline collaboration, >both Linux >and Buildroot. I was recently named one of the maintainers of the PCIe

Re: Synopsys Ethernet QoS Driver

2016-11-18 Thread Joao Pinto
Hello Ozgur, Thanks for your feedback. On 18-11-2016 13:09, mued dib wrote: > Dear Joao; > > thanks for support and this project is good. I have some questions, Linux > already support to QoS with "tc". right? > > Can you send us a list of driver files you are interested? For now we are