Re: hung task in mac80211

i confirm this patch fixes the issue for me as well Am 06.09.2017 um 17:04 schrieb Matteo Croce: On Wed, Sep 6, 2017 at 2:58 PM, Johannes Berg wrote: On Wed, 2017-09-06 at 13:57 +0200, Matteo Croce wrote: I have an hung task on vanilla 4.13 kernel which I haven't

Re: hung task in mac80211

On Wed, 2017-09-06 at 17:04 +0200, Matteo Croce wrote: > > I confirm that this patch fixes the hang too. Cool, I'll go apply it. > I'm curious to see if there are noticeable performance differences > between the two solutions. Nope, you hit this code path essentially once. johannes

Re: hung task in mac80211

On Wed, Sep 6, 2017 at 2:58 PM, Johannes Berg wrote: > On Wed, 2017-09-06 at 13:57 +0200, Matteo Croce wrote: > >> I have an hung task on vanilla 4.13 kernel which I haven't on 4.12. >> The problem is present both on my AP and on my notebook, >> so it seems it affects

Re: hung task in mac80211

On Wed, 2017-09-06 at 16:27 +0200, Stefano Brivio wrote: > > Sorry for the extended bothering :) but here, you're extending quite > a bit the scope of the lock also > when__ieee80211_start_rx_ba_session() is called by > ieee80211_process_addba_request(). I know, but it doesn't matter. > No idea

Re: hung task in mac80211

On Wed, 06 Sep 2017 14:58:48 +0200 Johannes Berg wrote: > +void __ieee80211_start_rx_ba_session(struct sta_info *sta, > + u8 dialog_token, u16 timeout, > + u16 start_seq_num, u16 ba_policy, u16 tid, > +

Re: hung task in mac80211

On Wed, 06 Sep 2017 15:30:10 +0200 Johannes Berg wrote: > So for example replacing the loop of tid = 0..NUM_TIDS-1 with a > list_for_each_entry() would already be unsafe with the dropping if the > list were to require the mutex for locking. Sure. Still, it would need

Re: hung task in mac80211

On Wed, 2017-09-06 at 15:27 +0200, Stefano Brivio wrote: > > Yes, that was based on the assumption that the initial part of > __ieee80211_start_rx_ba_session() can't really affect the AMPDU > state-machine in any way. That's not really the point, if that changes that function would have to move

Re: hung task in mac80211

On Wed, 2017-09-06 at 15:19 +0200, Stefano Brivio wrote: > On Wed, 06 Sep 2017 14:48:35 +0200 > Johannes Berg wrote: > > > I'll look in a bit - but > > > > > + mutex_unlock(>ampdu_mlme.mtx); > > >   ___ieee80211_stop_rx_ba_session( > >

Re: hung task in mac80211

On Wed, 06 Sep 2017 15:21:00 +0200 Johannes Berg wrote: > On Wed, 2017-09-06 at 15:19 +0200, Stefano Brivio wrote: > > On Wed, 06 Sep 2017 14:48:35 +0200 > > Johannes Berg wrote: > > > > > I'll look in a bit - but > > > > > > > +

Re: hung task in mac80211

Am 06.09.2017 um 15:03 schrieb Johannes Berg: On Wed, 2017-09-06 at 14:48 +0200, Johannes Berg wrote: I'm surprised nobody saw this before - though perhaps Sebastian's useless report is the same. Oh, that's because this is only for the offloaded manager thing, and that's only ath10k. johannes

Re: hung task in mac80211

On Wed, 06 Sep 2017 14:48:35 +0200 Johannes Berg wrote: > I'll look in a bit - but > > > + mutex_unlock(>ampdu_mlme.mtx); > >   ___ieee80211_stop_rx_ba_session( > >   sta, tid, WLAN_BACK_RECIPIENT, > >  

Re: hung task in mac80211

On Wed, Sep 6, 2017 at 2:40 PM, Stefano Brivio wrote: > On Wed, 6 Sep 2017 13:57:47 +0200 > Matteo Croce wrote: > >> Hi, >> >> I have an hung task on vanilla 4.13 kernel which I haven't on 4.12. >> The problem is present both on my AP and on my notebook, >>

Re: hung task in mac80211

On Wed, 2017-09-06 at 14:48 +0200, Johannes Berg wrote: > > I'm surprised nobody saw this before - though perhaps Sebastian's > useless report is the same. Oh, that's because this is only for the offloaded manager thing, and that's only ath10k. johannes

Re: hung task in mac80211

On Wed, 2017-09-06 at 13:57 +0200, Matteo Croce wrote: > I have an hung task on vanilla 4.13 kernel which I haven't on 4.12. > The problem is present both on my AP and on my notebook, > so it seems it affects AP and STA mode as well. > The generated messages are: > > INFO: task kworker/u16:6:120

Re: hung task in mac80211

I'll look in a bit - but > + mutex_unlock(>ampdu_mlme.mtx); >   ___ieee80211_stop_rx_ba_session( >   sta, tid, WLAN_BACK_RECIPIENT, >   WLAN_REASON_QSTA_TIMEOUT, true); This already has three

Re: hung task in mac80211

On Wed, 6 Sep 2017 13:57:47 +0200 Matteo Croce wrote: > Hi, > > I have an hung task on vanilla 4.13 kernel which I haven't on 4.12. > The problem is present both on my AP and on my notebook, > so it seems it affects AP and STA mode as well. > The generated messages are: > >

Re: hung task in mac80211

On Wednesday, September 6, 2017 1:57:47 PM CEST Matteo Croce wrote: > Hi, > > I have an hung task on vanilla 4.13 kernel which I haven't on 4.12. > The problem is present both on my AP and on my notebook, > so it seems it affects AP and STA mode as well. > The generated messages are: > > INFO: