Re: Why return E2BIG from bpf map update?

2015-07-21 Thread Alexei Starovoitov
On 7/21/15 3:13 AM, Alex Gartrell wrote: But, the EINVAL errno has similarly been abused to death there was a thread few month ago trying to come up with a generic solution for aliased error codes, but unfortunately nothing concrete came out of it. The one I liked sounded that the kernel may

Re: Why return E2BIG from bpf map update?

2015-07-21 Thread Alex Gartrell
On Tue, Jul 21, 2015 at 2:40 AM, Daniel Borkmann dan...@iogearbox.net wrote: On 07/21/2015 12:24 AM, Alexei Starovoitov wrote: On 7/20/15 3:15 PM, Alex Gartrell wrote: The ship has probably sailed on this one, but it seems like ENOSPC makes more sense than E2BIG. Any chance of changing it

Re: Why return E2BIG from bpf map update?

2015-07-21 Thread Daniel Borkmann
On 07/21/2015 12:24 AM, Alexei Starovoitov wrote: On 7/20/15 3:15 PM, Alex Gartrell wrote: The ship has probably sailed on this one, but it seems like ENOSPC makes more sense than E2BIG. Any chance of changing it so that poor ebpf library maintainers in the future don't have to wonder how

Why return E2BIG from bpf map update?

2015-07-20 Thread Alex Gartrell
The ship has probably sailed on this one, but it seems like ENOSPC makes more sense than E2BIG. Any chance of changing it so that poor ebpf library maintainers in the future don't have to wonder how their argument list got too big? net-next/master:kernel/bpf/hashtab.c=static int

Re: Why return E2BIG from bpf map update?

2015-07-20 Thread Alexei Starovoitov
On 7/20/15 3:15 PM, Alex Gartrell wrote: The ship has probably sailed on this one, but it seems like ENOSPC makes more sense than E2BIG. Any chance of changing it so that poor ebpf library maintainers in the future don't have to wonder how their argument list got too big? sorry, too late.