Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-27 Thread Robert P. J. Day
On Mon, 27 Aug 2018, Oliver Hartkopp wrote: > "released upon production" means usually: Oh, we put that driver in > a tar-ball on a CD that's shipped with the product and which will > get no further visibility nor (security) maintenance. > > Robert, please tell your manager that creating a driver

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-27 Thread Oliver Hartkopp
On 08/27/2018 08:20 AM, Robert P. J. Day wrote: On Sun, 26 Aug 2018, Stephen Hemminger wrote: On Sun, 26 Aug 2018 15:20:24 -0400 (EDT) "Robert P. J. Day" wrote: On Sun, 26 Aug 2018, Andrew Lunn wrote: i ask since, in my testing, when the interface should have been up, the attribute f

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
On Sun, 26 Aug 2018, Stephen Hemminger wrote: > On Sun, 26 Aug 2018 15:20:24 -0400 (EDT) > "Robert P. J. Day" wrote: > > > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > > > i ask since, in my testing, when the interface should have been > > > > up, the attribute file "operstate" for that inte

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Stephen Hemminger
On Sun, 26 Aug 2018 15:20:24 -0400 (EDT) "Robert P. J. Day" wrote: > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > i ask since, in my testing, when the interface should have been > > > up, the attribute file "operstate" for that interface showed > > > "unknown", and i wondered how worried i

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
On Sun, 26 Aug 2018, Andrew Lunn wrote: > On Sun, Aug 26, 2018 at 03:20:24PM -0400, Robert P. J. Day wrote: > > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > > > i ask since, in my testing, when the interface should have been > > > > up, the attribute file "operstate" for that interface showed

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Andrew Lunn
On Sun, Aug 26, 2018 at 03:20:24PM -0400, Robert P. J. Day wrote: > On Sun, 26 Aug 2018, Andrew Lunn wrote: > > > > i ask since, in my testing, when the interface should have been > > > up, the attribute file "operstate" for that interface showed > > > "unknown", and i wondered how worried i sho

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
On Sun, 26 Aug 2018, Andrew Lunn wrote: > > i ask since, in my testing, when the interface should have been > > up, the attribute file "operstate" for that interface showed > > "unknown", and i wondered how worried i should be about that. > > Hi Robert > > You should probably post the driver for

Re: confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Andrew Lunn
> i ask since, in my testing, when the interface should have been up, > the attribute file "operstate" for that interface showed "unknown", > and i wondered how worried i should be about that. Hi Robert You should probably post the driver for review. A well written driver should not even need t

confusing comment, explanation of @IFF_RUNNING in if.h

2018-08-26 Thread Robert P. J. Day
more annoying pedantry ... from include/uapi/linux/if.h: * @IFF_RUNNING: interface RFC2863 OPER_UP. Volatile. however, both the code in net/core/dev.c: /** * netif_oper_up - test if device is operational * @dev: network device * * Check if carrier is operational */ static