d80211 constants inside d80211_common.h

2006-12-27 Thread Nick Kossifidis
ieee80211_msg_type, ieee80211_phytype and ieee80211_ssi_type should be in capitals as they are constants and must not be mistaken for vars... enum ieee80211_msg_type { IEEE80211_MSG_NORMAL= 0, IEEE80211_MSG_TX_CALLBACK_ACK = 1, IEEE80211_MSG_TX_CALLBACK_FAIL

Re: d80211 constants inside d80211_common.h

2006-12-27 Thread Michael Wu
On Wednesday 27 December 2006 03:32, Nick Kossifidis wrote: I did a grep inside drivers/net/wireless/d80211/* and they are not used yet in drivers. Can you plz fix it before drivers start using them ? Already fixed, just waiting for wireless-dev to get it.

Re: d80211 constants inside d80211_common.h

2006-12-27 Thread Nick Kossifidis
We need those definitions for setting up the rate tables in dadwifi, phytypes are needed inside drivers, take a look here - http://madwifi.org/browser/branches/dadwifi-openhal/openhal/ar5xxx.h?rev=1867 Even if it does get out, constants should be in capitals. Thanx for your time Nick

Re: d80211 constants inside d80211_common.h

2006-12-27 Thread Nick Kossifidis
Anyway it's not a problem to get phytypes outside dadwifi, but i think it's low level stuff that's generaly needed. The main cause for my mail was to capitalize them, anywhere they get inside kernel source. Thanx for your time Nick 2006/12/27, Nick Kossifidis [EMAIL PROTECTED]: We need those

Re: d80211 constants inside d80211_common.h

2006-12-27 Thread Michael Wu
On Wednesday 27 December 2006 12:26, Nick Kossifidis wrote: We need those definitions for setting up the rate tables in dadwifi, phytypes are needed inside drivers, take a look here - http://madwifi.org/browser/branches/dadwifi-openhal/openhal/ar5xxx.h?rev=18 67 MODE_IEEE80211A/B/G and

Re: d80211 constants inside d80211_common.h

2006-12-27 Thread Nick Kossifidis
Thank you, i'll use directly IEEE80211_RATE_* ;-) Nick 2006/12/27, Michael Wu [EMAIL PROTECTED]: On Wednesday 27 December 2006 12:26, Nick Kossifidis wrote: We need those definitions for setting up the rate tables in dadwifi, phytypes are needed inside drivers, take a look here -